You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by gs...@apache.org on 2008/12/07 21:21:04 UTC
svn commit: r724190 - in /lucene/solr/trunk/contrib/extraction: build.xml
lib/commons-codec-1.3.jar lib/commons-io-1.4.jar lib/commons-lang-2.1.jar
lib/junit-3.8.1.jar
Author: gsingers
Date: Sun Dec 7 12:21:03 2008
New Revision: 724190
URL: http://svn.apache.org/viewvc?rev=724190&view=rev
Log:
SOLR-284: remove duplicated Tika libs
Removed:
lucene/solr/trunk/contrib/extraction/lib/commons-codec-1.3.jar
lucene/solr/trunk/contrib/extraction/lib/commons-io-1.4.jar
lucene/solr/trunk/contrib/extraction/lib/commons-lang-2.1.jar
lucene/solr/trunk/contrib/extraction/lib/junit-3.8.1.jar
Modified:
lucene/solr/trunk/contrib/extraction/build.xml
Modified: lucene/solr/trunk/contrib/extraction/build.xml
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/contrib/extraction/build.xml?rev=724190&r1=724189&r2=724190&view=diff
==============================================================================
--- lucene/solr/trunk/contrib/extraction/build.xml (original)
+++ lucene/solr/trunk/contrib/extraction/build.xml Sun Dec 7 12:21:03 2008
@@ -17,7 +17,7 @@
limitations under the License.
-->
-<project name="solr-extraction" default="build">
+<project name="solr-cell" default="build">
<property name="solr-path" value="../.." />
<property name="tika.version" value="0.2-SNAPSHOT"/>
@@ -33,7 +33,7 @@
<pathelement location="${solr-path}/build/solr" />
<pathelement location="${solr-path}/build/solrj" />
<fileset dir="lib" includes="*.jar"/>
- <fileset dir="${solr-path}/lib" includes="*.jar"></fileset>
+ <fileset dir="${solr-path}/lib" includes="*.jar"/>
</path>
<path id="test.classpath">
@@ -98,6 +98,17 @@
<fail if="tests.failed">Tests failed!</fail>
</target>
+ <target name="test-reports"
+ description="Generates HTML test reports.">
+ <mkdir dir="${junit.reports}"/>
+ <junitreport todir="${junit.output.dir}">
+ <fileset dir="${junit.output.dir}">
+ <include name="TEST-*.xml"/>
+ </fileset>
+ <report format="frames" todir="${junit.reports}"/>
+ </junitreport>
+ </target>
+
<target name="dist" depends="build">
</target>
Re: svn commit: r724190 - in /lucene/solr/trunk/contrib/extraction: build.xml lib/commons-codec-1.3.jar lib/commons-io-1.4.jar lib/commons-lang-2.1.jar lib/junit-3.8.1.jar
Posted by Grant Ingersoll <gs...@apache.org>.
Hmm, the tests pass w/o commons-lang, but they fail w/o commons-
logging. Sigh. I'll put lang back in.
On Dec 7, 2008, at 3:46 PM, Ryan McKinley wrote:
>
> On Dec 7, 2008, at 3:21 PM, gsingers@apache.org wrote:
>>
>> SOLR-284: remove duplicated Tika libs
>>
>> Removed:
>> lucene/solr/trunk/contrib/extraction/lib/commons-lang-2.1.jar
>
> My mistake, commons-lang is not in the root /lib, so this may cause
> some problem with dependent libraries.
>
> I don't know if it matters, but the velocity contrib uses commons-
> lang-2.4.jar
>
> Also, I see you did not remove: commons-logging.jar -- that may be
> fine, but note that jcl-over-slf4j-1.5.5.jar is a drop in
> replacement for commons-logging.jar -- this way anything using
> commons-logging can be handled exactly the same as if it were using
> the slf4j API.
>
> ryan
Re: svn commit: r724190 - in /lucene/solr/trunk/contrib/extraction: build.xml lib/commons-codec-1.3.jar lib/commons-io-1.4.jar lib/commons-lang-2.1.jar lib/junit-3.8.1.jar
Posted by Ryan McKinley <ry...@gmail.com>.
On Dec 7, 2008, at 3:21 PM, gsingers@apache.org wrote:
>
> SOLR-284: remove duplicated Tika libs
>
> Removed:
> lucene/solr/trunk/contrib/extraction/lib/commons-lang-2.1.jar
My mistake, commons-lang is not in the root /lib, so this may cause
some problem with dependent libraries.
I don't know if it matters, but the velocity contrib uses commons-
lang-2.4.jar
Also, I see you did not remove: commons-logging.jar -- that may be
fine, but note that jcl-over-slf4j-1.5.5.jar is a drop in replacement
for commons-logging.jar -- this way anything using commons-logging can
be handled exactly the same as if it were using the slf4j API.
ryan