You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/18 07:03:38 UTC

[GitHub] [flink] zoucao opened a new pull request, #19504: [FLINK-26761][table]invoke getTargetTableID to avoid type conversion exception

zoucao opened a new pull request, #19504:
URL: https://github.com/apache/flink/pull/19504

   ## What is the purpose of the change
     invoke getTargetTableID in PreValidateReWriter#appendPartitionAndNullsProjects to avoid type conversion exception.
   
   ## Brief change log
    - use RichSqlInsert#getTargetTableID to get 'SqlIdentifier' instead of SqlInsert#getTargetTable.
    - add test to verify.
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (100MB)*
     - *Extended integration test for recovery after master (JobManager) failure*
     - *Added test that validates that TaskInfo is transferred only once across recoveries*
     - *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
     - The S3 file system connector: (yes / no / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoucao closed pull request #19504: [FLINK-26761][table]invoke getTargetTableID to avoid type conversion exception

Posted by GitBox <gi...@apache.org>.
zoucao closed pull request #19504: [FLINK-26761][table]invoke getTargetTableID to avoid type conversion exception
URL: https://github.com/apache/flink/pull/19504


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoucao commented on pull request #19504: [FLINK-26761][table]invoke getTargetTableID to avoid type conversion exception

Posted by GitBox <gi...@apache.org>.
zoucao commented on PR #19504:
URL: https://github.com/apache/flink/pull/19504#issuecomment-1101161748

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoucao commented on pull request #19504: [FLINK-26761][table]invoke getTargetTableID to avoid type conversion exception

Posted by GitBox <gi...@apache.org>.
zoucao commented on PR #19504:
URL: https://github.com/apache/flink/pull/19504#issuecomment-1107695851

   Hi,  @godfreyhe, sry for pushing, do you have time to review it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19504: [FLINK-26761][table]invoke getTargetTableID to avoid type conversion exception

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19504:
URL: https://github.com/apache/flink/pull/19504#issuecomment-1101168942

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d3496e103f44f0dd827dfa7d257424ce1394a263",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d3496e103f44f0dd827dfa7d257424ce1394a263",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d3496e103f44f0dd827dfa7d257424ce1394a263 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoucao commented on pull request #19504: [FLINK-26761][table]invoke getTargetTableID to avoid type conversion exception

Posted by GitBox <gi...@apache.org>.
zoucao commented on PR #19504:
URL: https://github.com/apache/flink/pull/19504#issuecomment-1104666336

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoucao commented on pull request #19504: [FLINK-26761][table]invoke getTargetTableID to avoid type conversion exception

Posted by GitBox <gi...@apache.org>.
zoucao commented on PR #19504:
URL: https://github.com/apache/flink/pull/19504#issuecomment-1101162593

   Gentle ping @godfreyhe, could you help to confirm?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoucao commented on pull request #19504: [FLINK-26761][table]invoke getTargetTableID to avoid type conversion exception

Posted by GitBox <gi...@apache.org>.
zoucao commented on PR #19504:
URL: https://github.com/apache/flink/pull/19504#issuecomment-1101254297

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org