[GitHub] [pulsar] AlvaroStream opened a new pull request, #15307: [Improve][admin|client] AsyncHttpConnector doesn't use the system properties configured

[GitBox <gi...@apache.org>]

AlvaroStream opened a new pull request, #15307:
URL: https://github.com/apache/pulsar/pull/15307

   The AsyncHttpConnector will use the configuration inside System properties http.proxyHost and http.proxyPort
   
   It is recommended to use pulsar like this for example:
   
   PULSAR_EXTRA_OPTS="-Dhttps.proxyHost=<proxy> -Dhttps.proxyPort=<proxy_port> -Dhttp.proxyHost=<proxy> -Dhttp.proxyPort=<proxy_port>" bin/pulsar-admin tenants list
   
   Before this change the execution need to add the org.asynchttpclient.useProxyProperties that it is a little bit tricy to find.
   
   PULSAR_EXTRA_OPTS="-Dhttps.proxyHost=<proxy> -Dhttps.proxyPort=<proxy_port> -Dhttp.proxyHost=<proxy> -Dhttp.proxyPort=<proxy_port> -Dorg.asynchttpclient.useProxyProperties=true" bin/pulsar-admin tenants list
   
   ### Motivation
   
   When trying to use a web proxy with the pulsar-admin, the configuration was not taking into account unless the variable: org.asynchttpclient.useProxyProperties=true
   
   With this modification this will be done by default in all the cases where the asynchttpclient is used.
   
   ### Modifications
   
   Activate in the AsyncHTTPClient to take into account by default the ProxyProperties for the proxy.
   
   ### Verifying this change
   
   - [X ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [X ] `no-need-doc` 
   
   The 
   (Please explain why)
     


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- merged pull request #15307: [Improve][admin|client] AsyncHttpConnector doesn't use the system properties configured

[GitBox <gi...@apache.org>]

Technoboy- merged PR #15307:
URL: https://github.com/apache/pulsar/pull/15307


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org