You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2014/07/22 19:26:35 UTC
[GitHub] couchdb-couch pull request: Fix default CSP setting for Ace Editor
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-couch/pull/2
Fix default CSP setting for Ace Editor
Like @sebastianrothbucher noticed in apache/couchdb-fauxton#5
the Ace editor needs base64 image data as image source for their
icons
Please don't merge: I think I have to fix a test before this can get merged in apache/couchdb - will do that once eunit is merged and the travis builds are green again
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-couch fix-csp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit ceed602b70e1239cf4c81b1d6e33546a6ade6bd4
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-07-22T17:22:02Z
Fix default CSP setting for Ace Editor
Like @sebastianrothbucher noticed in apache/couchdb-fauxton#5
the Ace editor needs base64 image data as image source for their
icons
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Fix default CSP setting for Ace Editor
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-couch/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Fix default CSP setting for Ace Editor
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/2#issuecomment-64784274
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Fix default CSP setting for Ace Editor
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-couch/pull/2#issuecomment-64927832
merged as 741a82d4cfda424bba5545a2219ecc2c4cf919c3 - thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Fix default CSP setting for Ace Editor
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-couch/pull/2#issuecomment-54715495
FIxed the test. rebased & ready for review! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---