You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/18 04:34:24 UTC

[GitHub] [dubbo-go] beiwei30 opened a new pull request #943: introduce ConfigPostProcessor extension

beiwei30 opened a new pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943


   <!--  Thanks for sending a pull request!
   Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request. 
   -->
   
   **What this PR does**:
   
   introduce ConfigPostProcessor extension so that user can customize configs for both ServiceConfig and ReferenceConfig further during deployment time. 
   
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes #
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] beiwei30 commented on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
beiwei30 commented on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-748754275


   @watermelo in order to give more flexibility to the implementation. I introduce an empty interface for the parameter instead of a parameter's type, since people may need to look into other infos like interface or others. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] watermelo commented on a change in pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
watermelo commented on a change in pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#discussion_r546391572



##########
File path: config/interfaces/config_post_processor.go
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package interfaces
+
+// ConfigPostProcessor is an extension to give users a chance to customize configs against ReferenceConfig and
+// ServiceConfig during deployment time.
+type ConfigPostProcessor interface {
+	// PostProcessReferenceConfig customizes ReferenceConfig's params
+	PostProcessReferenceConfig(params *map[string]string)

Review comment:
       A map is just a pointer to a runtime.hmap structure, so we can replace`*map[string]string` -> `map[string]string`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] watermelo commented on a change in pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
watermelo commented on a change in pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#discussion_r546391572



##########
File path: config/interfaces/config_post_processor.go
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package interfaces
+
+// ConfigPostProcessor is an extension to give users a chance to customize configs against ReferenceConfig and
+// ServiceConfig during deployment time.
+type ConfigPostProcessor interface {
+	// PostProcessReferenceConfig customizes ReferenceConfig's params
+	PostProcessReferenceConfig(params *map[string]string)

Review comment:
       A map is just a pointer to a runtime.hmap structure, so we can replace`*map[string]string` -> `map[string]string`,.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-747893428


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=h1) Report
   > Merging [#943](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=desc) (8789da2) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **increase** coverage by `0.36%`.
   > The diff coverage is `36.36%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/943/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #943      +/-   ##
   ===========================================
   + Coverage    59.92%   60.29%   +0.36%     
   ===========================================
     Files          260      261       +1     
     Lines        12840    12896      +56     
   ===========================================
   + Hits          7695     7775      +80     
   + Misses        4186     4162      -24     
     Partials       959      959              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.50% <50.00%> (-0.18%)` | :arrow_down: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.18% <75.00%> (-0.45%)` | :arrow_down: |
   | [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `76.96% <0.00%> (-0.88%)` | :arrow_down: |
   | [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <0.00%> (-0.45%)` | :arrow_down: |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
   | [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `69.60% <0.00%> (+0.88%)` | :arrow_up: |
   | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `59.62% <0.00%> (+1.10%)` | :arrow_up: |
   | [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `67.36% <0.00%> (+2.10%)` | :arrow_up: |
   | ... and [7 more](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=footer). Last update [e2954fe...95432d1](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-747893428


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=h1) Report
   > Merging [#943](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=desc) (95432d1) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **increase** coverage by `0.23%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/943/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #943      +/-   ##
   ===========================================
   + Coverage    59.92%   60.16%   +0.23%     
   ===========================================
     Files          260      261       +1     
     Lines        12840    12895      +55     
   ===========================================
   + Hits          7695     7758      +63     
   + Misses        4186     4177       -9     
   - Partials       959      960       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.00% <50.00%> (-0.64%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.50% <50.00%> (-0.18%)` | :arrow_down: |
   | [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `76.96% <0.00%> (-0.88%)` | :arrow_down: |
   | [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <0.00%> (-0.45%)` | :arrow_down: |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
   | [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `68.54% <0.00%> (+1.08%)` | :arrow_up: |
   | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `59.62% <0.00%> (+1.10%)` | :arrow_up: |
   | [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `48.78% <0.00%> (+4.87%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=footer). Last update [e2954fe...95432d1](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-747893428


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=h1) Report
   > Merging [#943](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=desc) (f7938a3) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **increase** coverage by `0.30%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/943/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #943      +/-   ##
   ===========================================
   + Coverage    59.92%   60.23%   +0.30%     
   ===========================================
     Files          260      261       +1     
     Lines        12840    12895      +55     
   ===========================================
   + Hits          7695     7767      +72     
   + Misses        4186     4167      -19     
   - Partials       959      961       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.00% <50.00%> (-0.64%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.50% <50.00%> (-0.18%)` | :arrow_down: |
   | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
   | [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `76.96% <0.00%> (-0.88%)` | :arrow_down: |
   | [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <0.00%> (-0.45%)` | :arrow_down: |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
   | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `59.62% <0.00%> (+1.10%)` | :arrow_up: |
   | ... and [7 more](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=footer). Last update [e2954fe...78b29c7](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-747893428


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=h1) Report
   > Merging [#943](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=desc) (52405be) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **increase** coverage by `0.02%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/943/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #943      +/-   ##
   ===========================================
   + Coverage    59.92%   59.95%   +0.02%     
   ===========================================
     Files          260      261       +1     
     Lines        12840    12889      +49     
   ===========================================
   + Hits          7695     7727      +32     
   - Misses        4186     4204      +18     
   + Partials       959      958       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.00% <50.00%> (-0.64%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.50% <50.00%> (-0.18%)` | :arrow_down: |
   | [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-10.17%)` | :arrow_down: |
   | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
   | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `43.43% <0.00%> (-2.03%)` | :arrow_down: |
   | [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `76.96% <0.00%> (-0.88%)` | :arrow_down: |
   | [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <0.00%> (-0.45%)` | :arrow_down: |
   | [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `68.54% <0.00%> (+1.08%)` | :arrow_up: |
   | ... and [4 more](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=footer). Last update [e2954fe...52405be](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-747893428


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=h1) Report
   > Merging [#943](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=desc) (afab2dc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **decrease** coverage by `0.34%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/943/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #943      +/-   ##
   ===========================================
   - Coverage    59.92%   59.58%   -0.35%     
   ===========================================
     Files          260      261       +1     
     Lines        12840    12895      +55     
   ===========================================
   - Hits          7695     7683      -12     
   - Misses        4186     4257      +71     
   + Partials       959      955       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.00% <50.00%> (-0.64%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.50% <50.00%> (-0.18%)` | :arrow_down: |
   | [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `17.24% <0.00%> (-47.35%)` | :arrow_down: |
   | [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-10.17%)` | :arrow_down: |
   | [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.72% <0.00%> (-3.04%)` | :arrow_down: |
   | [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `76.96% <0.00%> (-0.88%)` | :arrow_down: |
   | [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (ø)` | |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
   | ... and [8 more](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=footer). Last update [e2954fe...afab2dc](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-747893428


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=h1) Report
   > Merging [#943](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=desc) (78b29c7) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **increase** coverage by `0.33%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/943/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #943      +/-   ##
   ===========================================
   + Coverage    59.92%   60.26%   +0.33%     
   ===========================================
     Files          260      261       +1     
     Lines        12840    12895      +55     
   ===========================================
   + Hits          7695     7771      +76     
   + Misses        4186     4165      -21     
     Partials       959      959              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.00% <50.00%> (-0.64%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.50% <50.00%> (-0.18%)` | :arrow_down: |
   | [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `76.96% <0.00%> (-0.88%)` | :arrow_down: |
   | [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <0.00%> (-0.45%)` | :arrow_down: |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
   | [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `69.60% <0.00%> (+0.88%)` | :arrow_up: |
   | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `59.62% <0.00%> (+1.10%)` | :arrow_up: |
   | ... and [7 more](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=footer). Last update [e2954fe...afab2dc](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-747893428


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=h1) Report
   > Merging [#943](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=desc) (78b29c7) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **increase** coverage by `0.25%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/943/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #943      +/-   ##
   ===========================================
   + Coverage    59.92%   60.18%   +0.25%     
   ===========================================
     Files          260      261       +1     
     Lines        12840    12895      +55     
   ===========================================
   + Hits          7695     7761      +66     
   + Misses        4186     4174      -12     
   - Partials       959      960       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.00% <50.00%> (-0.64%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.50% <50.00%> (-0.18%)` | :arrow_down: |
   | [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <0.00%> (-8.34%)` | :arrow_down: |
   | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
   | [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `76.96% <0.00%> (-0.88%)` | :arrow_down: |
   | [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <0.00%> (-0.45%)` | :arrow_down: |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
   | ... and [8 more](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=footer). Last update [e2954fe...afab2dc](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] beiwei30 commented on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
beiwei30 commented on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-749424601


   @AlexStocks @watermelo @cityiron would you mind to review the new solution again?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-747893428


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=h1) Report
   > Merging [#943](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=desc) (f7938a3) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **increase** coverage by `0.30%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/943/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #943      +/-   ##
   ===========================================
   + Coverage    59.92%   60.23%   +0.30%     
   ===========================================
     Files          260      261       +1     
     Lines        12840    12895      +55     
   ===========================================
   + Hits          7695     7767      +72     
   + Misses        4186     4167      -19     
   - Partials       959      961       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.00% <50.00%> (-0.64%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.50% <50.00%> (-0.18%)` | :arrow_down: |
   | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
   | [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `76.96% <0.00%> (-0.88%)` | :arrow_down: |
   | [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <0.00%> (-0.45%)` | :arrow_down: |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
   | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `59.62% <0.00%> (+1.10%)` | :arrow_up: |
   | ... and [7 more](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=footer). Last update [e2954fe...afab2dc](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-747893428


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=h1) Report
   > Merging [#943](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=desc) (f7938a3) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **increase** coverage by `0.18%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/943/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #943      +/-   ##
   ===========================================
   + Coverage    59.92%   60.11%   +0.18%     
   ===========================================
     Files          260      261       +1     
     Lines        12840    12895      +55     
   ===========================================
   + Hits          7695     7752      +57     
   + Misses        4186     4184       -2     
     Partials       959      959              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.00% <50.00%> (-0.64%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.50% <50.00%> (-0.18%)` | :arrow_down: |
   | [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-10.17%)` | :arrow_down: |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `57.60% <0.00%> (-3.27%)` | :arrow_down: |
   | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
   | [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `76.96% <0.00%> (-0.88%)` | :arrow_down: |
   | [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <0.00%> (-0.45%)` | :arrow_down: |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
   | ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=footer). Last update [e2954fe...f7938a3](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] beiwei30 commented on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
beiwei30 commented on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-748759560


   pls. hold on, I am still working on a better idea.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-747893428


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=h1) Report
   > Merging [#943](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=desc) (8789da2) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **increase** coverage by `0.11%`.
   > The diff coverage is `36.36%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/943/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #943      +/-   ##
   ===========================================
   + Coverage    59.92%   60.04%   +0.11%     
   ===========================================
     Files          260      261       +1     
     Lines        12840    12896      +56     
   ===========================================
   + Hits          7695     7743      +48     
   - Misses        4186     4196      +10     
   + Partials       959      957       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.50% <50.00%> (-0.18%)` | :arrow_down: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.18% <75.00%> (-0.45%)` | :arrow_down: |
   | [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-10.17%)` | :arrow_down: |
   | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
   | [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `76.96% <0.00%> (-0.88%)` | :arrow_down: |
   | [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <0.00%> (-0.45%)` | :arrow_down: |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
   | [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `69.60% <0.00%> (+0.88%)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=footer). Last update [e2954fe...8789da2](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-747893428


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=h1) Report
   > Merging [#943](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=desc) (f7938a3) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **increase** coverage by `0.30%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/943/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #943      +/-   ##
   ===========================================
   + Coverage    59.92%   60.23%   +0.30%     
   ===========================================
     Files          260      261       +1     
     Lines        12840    12895      +55     
   ===========================================
   + Hits          7695     7767      +72     
   + Misses        4186     4167      -19     
   - Partials       959      961       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.00% <50.00%> (-0.64%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.50% <50.00%> (-0.18%)` | :arrow_down: |
   | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
   | [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `76.96% <0.00%> (-0.88%)` | :arrow_down: |
   | [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <0.00%> (-0.45%)` | :arrow_down: |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
   | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `59.62% <0.00%> (+1.10%)` | :arrow_up: |
   | ... and [7 more](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=footer). Last update [e2954fe...f7938a3](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-747893428


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=h1) Report
   > Merging [#943](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=desc) (52405be) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **increase** coverage by `0.29%`.
   > The diff coverage is `22.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/943/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #943      +/-   ##
   ===========================================
   + Coverage    59.92%   60.22%   +0.29%     
   ===========================================
     Files          260      261       +1     
     Lines        12840    12889      +49     
   ===========================================
   + Hits          7695     7763      +68     
   + Misses        4186     4166      -20     
   - Partials       959      960       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.00% <50.00%> (-0.64%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.50% <50.00%> (-0.18%)` | :arrow_down: |
   | [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `76.96% <0.00%> (-0.88%)` | :arrow_down: |
   | [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <0.00%> (-0.45%)` | :arrow_down: |
   | [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `68.54% <0.00%> (+1.08%)` | :arrow_up: |
   | [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `67.36% <0.00%> (+2.10%)` | :arrow_up: |
   | [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (+2.17%)` | :arrow_up: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `53.68% <0.00%> (+3.15%)` | :arrow_up: |
   | ... and [4 more](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=footer). Last update [e2954fe...f7938a3](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] beiwei30 commented on a change in pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
beiwei30 commented on a change in pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#discussion_r546481163



##########
File path: config/interfaces/config_post_processor.go
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package interfaces
+
+// ConfigPostProcessor is an extension to give users a chance to customize configs against ReferenceConfig and
+// ServiceConfig during deployment time.
+type ConfigPostProcessor interface {
+	// PostProcessReferenceConfig customizes ReferenceConfig's params
+	PostProcessReferenceConfig(params *map[string]string)

Review comment:
       got it, and fixed. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #943: introduce ConfigPostProcessor extension

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #943:
URL: https://github.com/apache/dubbo-go/pull/943#issuecomment-747893428


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=h1) Report
   > Merging [#943](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=desc) (6ac14f8) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **increase** coverage by `0.30%`.
   > The diff coverage is `64.94%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/943/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #943      +/-   ##
   ===========================================
   + Coverage    59.92%   60.23%   +0.30%     
   ===========================================
     Files          260      261       +1     
     Lines        12840    12895      +55     
   ===========================================
   + Hits          7695     7767      +72     
   + Misses        4186     4167      -19     
   - Partials       959      961       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `70.16% <ø> (+2.70%)` | :arrow_up: |
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
   | [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `64.13% <0.00%> (-0.45%)` | :arrow_down: |
   | [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `76.96% <0.00%> (-0.88%)` | :arrow_down: |
   | [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `50.36% <0.00%> (ø)` | |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.00% <50.00%> (-0.64%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.50% <50.00%> (-0.18%)` | :arrow_down: |
   | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `79.72% <75.75%> (+5.71%)` | :arrow_up: |
   | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `59.62% <78.57%> (+1.10%)` | :arrow_up: |
   | ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/943/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=footer). Last update [e2954fe...8789da2](https://codecov.io/gh/apache/dubbo-go/pull/943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org