You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/23 03:14:40 UTC
[GitHub] [hudi] nsivabalan commented on a change in pull request #4037: [HUDI-2794] Guarding table service commits within a single lock to commit to both data table and metadata table
nsivabalan commented on a change in pull request #4037:
URL: https://github.com/apache/hudi/pull/4037#discussion_r754778393
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java
##########
@@ -205,31 +205,19 @@ private HoodieCleanMetadata runClean(HoodieTable<T, I, K, O> table, HoodieInstan
Option.of(timer.endTimer()),
cleanStats
);
- writeMetadata(metadata);
+ if (!skipLocking && config.isMetadataTableEnabled()) {
+ this.txnManager.beginTransaction(Option.empty(), Option.empty());
+ }
+ writeTableMetadata(metadata);
Review comment:
yes, you are right. it will be no-op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org