[GitHub] [superset] bkyryliuk commented on a diff in pull request #24984: fix(hive): Remove unused async arg from execute query func to get hive connector working

["bkyryliuk (via GitHub)" <gi...@apache.org>]

bkyryliuk commented on code in PR #24984:
URL: https://github.com/apache/superset/pull/24984#discussion_r1312463056


##########
superset/db_engine_specs/hive.py:
##########
@@ -542,11 +542,9 @@ def update_impersonation_config(
             connect_args["configuration"] = configuration
 
     @staticmethod
-    def execute(  # type: ignore
-        cursor, query: str, async_: bool = False
-    ):  # pylint: disable=arguments-differ
-        kwargs = {"async": async_}
-        cursor.execute(query, **kwargs)
+    def execute(cursor, query: str):

Review Comment:
   `databricks+connector` works for me for schema selection as well. this is in 3.0.0.rc3 version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org