[GitHub] [storm] Ethanlm edited a comment on pull request #3377: [STORM-3404]KafkaOffsetLagUtil cant pull the offset correctly

[GitBox <gi...@apache.org>]

Ethanlm edited a comment on pull request #3377:
URL: https://github.com/apache/storm/pull/3377#issuecomment-800633946


   @wxy929629  Thanks for contributing!
   
   Can you please help me understand this problem better? 
   
   Do you mean when Kafka broker is set up with SASL_PLAIN, missing sasl.mechanism will lead to failures? If in that case, does it make sense to provide an option for users to choose `sasl.mechanism`, just like what we have for security.protocol ? https://github.com/apache/storm/blob/master/external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaOffsetLagUtil.java#L118
   
   Can you please explain more on what happened, by providing stack trace and logs if possible? Also the jira indicates it is tested on storm 1.2.2.  Can you provide the logs and stack trace from the testing from storm master branch?  Although I understand this is mostly about kafka client setup, not very related to storm version, but it is still nice to see since this PR is based on storm master branch.  It will help reviewers and other storm users to understand this better.
   
   Also did you test this with Kafka-1.x and make sure it still works?
   
   
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org