You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by se...@apache.org on 2015/06/30 03:21:47 UTC
[54/57] [abbrv] hive git commit: HIVE-7180 BufferedReader is not
closed in MetaStoreSchemaInfo (Alexander Pivovarov, reviewed by Xuefu Zhang)
HIVE-7180 BufferedReader is not closed in MetaStoreSchemaInfo (Alexander Pivovarov, reviewed by Xuefu Zhang)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/2272443c
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/2272443c
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/2272443c
Branch: refs/heads/llap
Commit: 2272443c99d8250d99cffaa77481168aecd45d15
Parents: 2e08e5d
Author: Alexander Pivovarov <ap...@gmail.com>
Authored: Fri Jun 26 20:42:39 2015 -0700
Committer: Alexander Pivovarov <ap...@gmail.com>
Committed: Sun Jun 28 22:27:06 2015 -0700
----------------------------------------------------------------------
.../org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/2272443c/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java
----------------------------------------------------------------------
diff --git a/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java b/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java
index a5eed6d..d72267d 100644
--- a/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java
+++ b/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java
@@ -19,6 +19,7 @@ package org.apache.hadoop.hive.metastore;
import java.io.BufferedReader;
import java.io.File;
+import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.FileReader;
import java.io.IOException;
@@ -62,9 +63,8 @@ public class MetaStoreSchemaInfo {
List<String> upgradeOrderList = new ArrayList<String>();
String upgradeListFile = getMetaStoreScriptDir() + File.separator +
VERSION_UPGRADE_LIST + "." + dbType;
- try {
- BufferedReader bfReader =
- new BufferedReader(new FileReader(upgradeListFile));
+ try (FileReader fr = new FileReader(upgradeListFile);
+ BufferedReader bfReader = new BufferedReader(fr)) {
String currSchemaVersion;
while ((currSchemaVersion = bfReader.readLine()) != null) {
upgradeOrderList.add(currSchemaVersion.trim());