[jira] [Commented] (VELOCITY-892) Method arguments conversions should be based on Type instead of Class

["Claude Brisson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VELOCITY-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650046#comment-16650046 ] 

Claude Brisson commented on VELOCITY-892:
-----------------------------------------

{quote}for example if the parameter type is List<String> it won't do the same thing than if the type is List<Integer>
{quote}
Since it's invalid in Java to have two methods with the same name and same argument type *after* type erasure, this use case doesn't stand, does it? Or can you be more explicit?

And if you have other typical use cases in mind where Velocity doesn't have the proper behavior, can you share them?

 

> Method arguments conversions should be based on Type instead of Class
> ---------------------------------------------------------------------
>
>                 Key: VELOCITY-892
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-892
>             Project: Velocity
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: 2.0
>            Reporter: Thomas Mortagne
>            Priority: Major
>             Fix For: 2.0
>
>
> I was happy to see that method arguments conversion has been added to 2.0 so that I can remove the uberspector we have on XWiki side but unfortunately ConversionHandler is limited to classes which is way too restrictive for us (for example if the parameter type is List<String> it won't do the same thing than if the type is List<Integer>).
> Our uberspector can be found on https://github.com/xwiki/xwiki-commons/blob/master/xwiki-commons-core/xwiki-commons-velocity/src/main/java/org/xwiki/velocity/introspection/MethodArgumentsUberspector.java to see what we do exactly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org