[GitHub] [arrow] yyang52 commented on issue #35287: [C++][Parquet] Expose the API to fine tune the window_bits parameter of ZLIB compression

["yyang52 (via GitHub)" <gi...@apache.org>]

yyang52 commented on issue #35287:
URL: https://github.com/apache/arrow/issues/35287#issuecomment-1518984661

   > I'm OK with make `window_bits` customizable. But I don't think that calling `MakeGZipCodec()` from `cpp/parquet/` directly is a good idea. Currently, we use `Codec::Create()` instead of `Make*Codec()` directly in `cpp/parquet/`.
   > 
   > I don't think that adding a new parameter `Codec::Create()` such as `Codec::Create(Compression::type codec, int compression_level, int window_bits)` is a good idea. If we choose this approach, we may need to add more parameters later. I like that we introduce a new options class such as `Codec::Options` but it may be too complex.
   > 
   > I suggest that we discuss API on `dev@arrow.apache.org` too.
   
   Thanks for your suggestion @kou! I agree that introducing a new option class is a better design and will make the extension of the parameters much easier. And it's also true that it will be more complex to do such a refactor. Do I need to initialize a discussion on `dev@arrow.apache.org` cause I have not used that before, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org