You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Adrian Crum (JIRA)" <ji...@apache.org> on 2009/08/25 02:16:59 UTC
[jira] Commented: (OFBIZ-2856) ordermgr -- productsummary.ftl (rev
797259) contains hard coded labels
[ https://issues.apache.org/jira/browse/OFBIZ-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747154#action_12747154 ]
Adrian Crum commented on OFBIZ-2856:
------------------------------------
Carsten,
It would be helpful if you submitted a patch. Patches are faster and easier for committers to review and commit.
Also, take a look at this document - http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices.
> ordermgr -- productsummary.ftl (rev 797259) contains hard coded labels
> ----------------------------------------------------------------------
>
> Key: OFBIZ-2856
> URL: https://issues.apache.org/jira/browse/OFBIZ-2856
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: irrelevant; bug in ftl screendef
> Reporter: Carsten Schinzer
> Priority: Minor
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> line 104 ff. are curremtly defined as:
> <div>
> <#if (sizeProductFeatureAndAppls?size == 1)>
> Size:
> <#else>
> Available Sizes:
> </#if>
> However, in order to enable proper i18n, these lines should rather read
> <div>
> <#if (sizeProductFeatureAndAppls?size == 1)>
> ${uiLabelMap.SingleSizeAvailable}:
> <#else>
> ${uiLabelMap.MultipleSizesAvailable}:
> </#if>
> ... and corresponding UI Labels added to order/config/OrderUiLables.xml.
> I've added the following locales to OrderUiLabels.xml:
> <property key="SingleSizeAvailable">
> <value xml:lang="de">Größe</value>
> <value xml:lang="en">Size</value>
> <value xml:lang="fr">Taille</value>
> </property>
> <property key="MultipleSizesAvailable">
> <value xml:lang="de">Verfügbare Größen</value>
> <value xml:lang="en">Sizes Available</value>
> <value xml:lang="fr">Tailles Disponibles</value>
> </property>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.