You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by sk...@apache.org on 2006/01/16 02:25:26 UTC

svn commit: r369299 - /myfaces/api/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java

Author: skitching
Date: Sun Jan 15 17:25:23 2006
New Revision: 369299

URL: http://svn.apache.org/viewcvs?rev=369299&view=rev
Log:
Add comments only.

Modified:
    myfaces/api/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java

Modified: myfaces/api/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java
URL: http://svn.apache.org/viewcvs/myfaces/api/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java?rev=369299&r1=369298&r2=369299&view=diff
==============================================================================
--- myfaces/api/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java (original)
+++ myfaces/api/trunk/api/src/main/java/javax/faces/webapp/UIComponentTag.java Sun Jan 15 17:25:23 2006
@@ -546,12 +546,22 @@
         else
         {
             //Child
+            //
+            // Note that setProperties is called only when we create the
+            // component; on later passes, the attributes defined on the
+            // JSP tag are set on this Tag object, but then completely
+            // ignored.
+
             String id = getOrCreateUniqueId(context);
             
             // Warn users that this tag is about to find/steal the UIComponent
             // that has already been created for a sibling tag with the same id value .
             // _childrenAdded is a Set, and we will stomp over a past id when calling 
             // addChildIdToParentTag.
+            //
+            // It would also be reasonable to throw an exception here rather than
+            // just issue a warning as this is a pretty serious problem. However the
+            // Sun RI just issues a warning...
             if(parentTag._childrenAdded != null && parentTag._childrenAdded.contains(id))
             {
                 log.warn("There is more than one JSF tag with an id of " + id);