You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Wolfgang Kritzinger (JIRA)" <ji...@apache.org> on 2012/09/12 23:31:08 UTC
[jira] [Created] (WICKET-4758) Fix created in WICKET-3916 is not
effective
Wolfgang Kritzinger created WICKET-4758:
-------------------------------------------
Summary: Fix created in WICKET-3916 is not effective
Key: WICKET-4758
URL: https://issues.apache.org/jira/browse/WICKET-4758
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 6.0.0, 1.5.0
Reporter: Wolfgang Kritzinger
The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java#L2506
As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4758) Fix created in WICKET-3916 is not
effective
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-4758:
-------------------------------------
Fix Version/s: (was: 6.0.1)
which versions work and don't work? Rather unclear what the status is of this issue.
Removed fix for 6.0.1 as we'll probably never release 6.0.1
> Fix created in WICKET-3916 is not effective
> -------------------------------------------
>
> Key: WICKET-4758
> URL: https://issues.apache.org/jira/browse/WICKET-4758
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0, 6.0.0
> Reporter: Wolfgang Kritzinger
> Fix For: 1.5.9
>
> Attachments: filter-columns2.tar.gz, WICKET-4758.patch
>
>
> The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java#L2506
> As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4758) Fix created in WICKET-3916 is not
effective
Posted by "Wolfgang Kritzinger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wolfgang Kritzinger updated WICKET-4758:
----------------------------------------
Reopening
> Fix created in WICKET-3916 is not effective
> -------------------------------------------
>
> Key: WICKET-4758
> URL: https://issues.apache.org/jira/browse/WICKET-4758
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0, 6.0.0
> Reporter: Wolfgang Kritzinger
> Assignee: Jeremy Thomerson
> Fix For: 6.0.1, 1.5.9
>
> Attachments: filter-columns2.tar.gz, WICKET-4758.patch
>
>
> The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java#L2506
> As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (WICKET-4758) DOM ids change of the input fields of
FilterToolbar
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst closed WICKET-4758.
------------------------------------
Resolution: Fixed
> DOM ids change of the input fields of FilterToolbar
> ---------------------------------------------------
>
> Key: WICKET-4758
> URL: https://issues.apache.org/jira/browse/WICKET-4758
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.8, 6.0.0
> Reporter: Wolfgang Kritzinger
> Fix For: 6.1.0
>
> Attachments: filter-columns2.tar.gz, WICKET-4758.patch
>
>
> The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java#L2506
> As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4758) Fix created in WICKET-3916 is not
effective
Posted by "Wolfgang Kritzinger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wolfgang Kritzinger updated WICKET-4758:
----------------------------------------
Affects Version/s: (was: 1.5.0)
1.5.8
> Fix created in WICKET-3916 is not effective
> -------------------------------------------
>
> Key: WICKET-4758
> URL: https://issues.apache.org/jira/browse/WICKET-4758
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.8, 6.0.0
> Reporter: Wolfgang Kritzinger
> Fix For: 1.5.9
>
> Attachments: filter-columns2.tar.gz, WICKET-4758.patch
>
>
> The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java#L2506
> As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4758) Fix created in WICKET-3916 is not
effective
Posted by "Wolfgang Kritzinger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455255#comment-13455255 ]
Wolfgang Kritzinger commented on WICKET-4758:
---------------------------------------------
This particular problem is solved; the id attribute is now rendered, however the FilterToolbar component still doesn't work right. It uses a RefreshingView so the markupIds of the input field change constantly after a submit, so on the next page, the JavaScript is not able to change the focus to the element again (because the HTML id attribute has changed).
I'll attach a quickstart and a proposed patch.
> Fix created in WICKET-3916 is not effective
> -------------------------------------------
>
> Key: WICKET-4758
> URL: https://issues.apache.org/jira/browse/WICKET-4758
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0, 6.0.0
> Reporter: Wolfgang Kritzinger
> Assignee: Jeremy Thomerson
> Fix For: 6.0.1, 1.5.9
>
> Attachments: filter-columns2.tar.gz, WICKET-4758.patch
>
>
> The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java#L2506
> As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4758) Fix created in WICKET-3916 is not
effective
Posted by "Wolfgang Kritzinger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wolfgang Kritzinger updated WICKET-4758:
----------------------------------------
Attachment: filter-columns2.tar.gz
Basic DefaultDataTable with only one column
> Fix created in WICKET-3916 is not effective
> -------------------------------------------
>
> Key: WICKET-4758
> URL: https://issues.apache.org/jira/browse/WICKET-4758
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0, 6.0.0
> Reporter: Wolfgang Kritzinger
> Assignee: Jeremy Thomerson
> Fix For: 6.0.1, 1.5.9
>
> Attachments: filter-columns2.tar.gz, WICKET-4758.patch
>
>
> The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java#L2506
> As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4758) Fix created in WICKET-3916 is not
effective
Posted by "Wolfgang Kritzinger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wolfgang Kritzinger updated WICKET-4758:
----------------------------------------
Attachment: WICKET-4758.patch
proposed patch against master
> Fix created in WICKET-3916 is not effective
> -------------------------------------------
>
> Key: WICKET-4758
> URL: https://issues.apache.org/jira/browse/WICKET-4758
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0, 6.0.0
> Reporter: Wolfgang Kritzinger
> Assignee: Jeremy Thomerson
> Fix For: 6.0.1, 1.5.9
>
> Attachments: filter-columns2.tar.gz, WICKET-4758.patch
>
>
> The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java#L2506
> As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4758) Fix created in WICKET-3916 is not
effective
Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Thomerson resolved WICKET-4758.
--------------------------------------
Resolution: Fixed
Fix Version/s: 1.5.9
6.0.1
Assignee: Jeremy Thomerson
This should fix it, but I don't currently have an easy way to test it. Please verify and re-open this issue if it's not fixed.
Master: https://git-wip-us.apache.org/repos/asf?p=wicket.git;a=commit;h=c274a707c2929e853907d3bd9b64e1582c16faac
1.5.x: https://git-wip-us.apache.org/repos/asf?p=wicket.git;a=commit;h=ac7748671472ac7d4f3f82e8801b607d3f73e5c2
> Fix created in WICKET-3916 is not effective
> -------------------------------------------
>
> Key: WICKET-4758
> URL: https://issues.apache.org/jira/browse/WICKET-4758
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0, 6.0.0
> Reporter: Wolfgang Kritzinger
> Assignee: Jeremy Thomerson
> Fix For: 6.0.1, 1.5.9
>
>
> The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java#L2506
> As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (WICKET-4758) Fix created in WICKET-3916 is not
effective
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reopened WICKET-4758:
-------------------------------------
Assignee: (was: Jeremy Thomerson)
> Fix created in WICKET-3916 is not effective
> -------------------------------------------
>
> Key: WICKET-4758
> URL: https://issues.apache.org/jira/browse/WICKET-4758
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0, 6.0.0
> Reporter: Wolfgang Kritzinger
> Fix For: 6.0.1, 1.5.9
>
> Attachments: filter-columns2.tar.gz, WICKET-4758.patch
>
>
> The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java#L2506
> As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4758) DOM ids change of the input fields
of FilterToolbar
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-4758:
-------------------------------------
Summary: DOM ids change of the input fields of FilterToolbar (was: Fix created in WICKET-3916 is not effective)
> DOM ids change of the input fields of FilterToolbar
> ---------------------------------------------------
>
> Key: WICKET-4758
> URL: https://issues.apache.org/jira/browse/WICKET-4758
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.8, 6.0.0
> Reporter: Wolfgang Kritzinger
> Fix For: 6.1.0
>
> Attachments: filter-columns2.tar.gz, WICKET-4758.patch
>
>
> The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java#L2506
> As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4758) Fix created in WICKET-3916 is not
effective
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-4758:
-------------------------------------
Fix Version/s: (was: 1.5.9)
6.1.0
Fixed for 6.1.0, as the patch doesn't apply to 1.5.8 and I want to release 6.1.0 now.
> Fix created in WICKET-3916 is not effective
> -------------------------------------------
>
> Key: WICKET-4758
> URL: https://issues.apache.org/jira/browse/WICKET-4758
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.8, 6.0.0
> Reporter: Wolfgang Kritzinger
> Fix For: 6.1.0
>
> Attachments: filter-columns2.tar.gz, WICKET-4758.patch
>
>
> The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java#L2506
> As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4758) Fix created in WICKET-3916 is not
effective
Posted by "Wolfgang Kritzinger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462582#comment-13462582 ]
Wolfgang Kritzinger commented on WICKET-4758:
---------------------------------------------
I'm sorry for the lack of clarity, this issue is present in 1.5.8 and 6.0.0 (and master for that matter - the supplied patch is against master)
> Fix created in WICKET-3916 is not effective
> -------------------------------------------
>
> Key: WICKET-4758
> URL: https://issues.apache.org/jira/browse/WICKET-4758
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5.0, 6.0.0
> Reporter: Wolfgang Kritzinger
> Fix For: 1.5.9
>
> Attachments: filter-columns2.tar.gz, WICKET-4758.patch
>
>
> The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java#L2506
> As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira