You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/02/14 07:02:52 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #40007: [SPARK-42324][CONNECT][TESTS][FOLLOW-UP] Fix failed test
zhengruifeng opened a new pull request, #40007:
URL: https://github.com/apache/spark/pull/40007
### What changes were proposed in this pull request?
```
[info] - Write to Path with invalid input *** FAILED *** (298 milliseconds)
[info] Expected exception org.apache.spark.SparkClassNotFoundException to be thrown, but no exception was thrown (SparkConnectProtoSuite.scala:605)
[info] org.scalatest.exceptions.TestFailedException:
[info] at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info] at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
[info] at org.scalatest.funsuite.AnyFunSuite.newAssertionFailedException(AnyFunSuite.scala:1564)
[info] at org.scalatest.Assertions.assertThrows(Assertions.scala:825)
[info] at org.scalatest.Assertions.assertThrows$(Assertions.scala:804)
[info] at org.scalatest.funsuite.AnyFunSuite.assertThrows(AnyFunSuite.scala:1564)
```
### Why are the changes needed?
master was broken
### Does this PR introduce _any_ user-facing change?
no, test-only
### How was this patch tested?
manually test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40007: [SPARK-41818][SPARK-42000][CONNECT][TESTS][FOLLOWUP] Fix failed test in SparkConnectProtoSuite
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40007:
URL: https://github.com/apache/spark/pull/40007#issuecomment-1429234279
cc @HyukjinKwon @ueshin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #40007: [SPARK-41818][SPARK-42000][CONNECT][TESTS][FOLLOWUP] Fix failed test in SparkConnectProtoSuite
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #40007: [SPARK-41818][SPARK-42000][CONNECT][TESTS][FOLLOWUP] Fix failed test in SparkConnectProtoSuite
URL: https://github.com/apache/spark/pull/40007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40007: [SPARK-41818][SPARK-42000][CONNECT][TESTS][FOLLOWUP] Fix failed test in SparkConnectProtoSuite
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40007:
URL: https://github.com/apache/spark/pull/40007#issuecomment-1429261134
close this one in favor of https://github.com/apache/spark/pull/40006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org