You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Antal Bálint Steinbach (JIRA)" <ji...@apache.org> on 2018/11/10 11:30:00 UTC
[jira] [Commented] (YARN-5106) Provide a builder interface for
FairScheduler allocations for use in tests
[ https://issues.apache.org/jira/browse/YARN-5106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682352#comment-16682352 ]
Antal Bálint Steinbach commented on YARN-5106:
----------------------------------------------
Hi [~snemeth] ,
Thanks for the patch, it cleans up the code a lot.
I would suggest some minor things:
# In AllocationFileQueue _renderInternal_ is not necessary
# Not strongly related to your fix but in some tc (TestAllocationFileLoaderService) you added a deletion for the alloc file, still, some test cases do not delete them. I did not check all but for example ReservationACLsTestBase. There can be others.
> Provide a builder interface for FairScheduler allocations for use in tests
> --------------------------------------------------------------------------
>
> Key: YARN-5106
> URL: https://issues.apache.org/jira/browse/YARN-5106
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Affects Versions: 2.8.0
> Reporter: Karthik Kambatla
> Assignee: Szilard Nemeth
> Priority: Major
> Labels: newbie++
> Attachments: YARN-5106.001.patch, YARN-5106.002.patch
>
>
> Most, if not all, fair scheduler tests create an allocations XML file. Having a helper class that potentially uses a builder would make the tests cleaner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org