You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/10 19:47:57 UTC

[GitHub] [tvm] areusch commented on a diff in pull request #11657: [CI] Apply linting rules to AOT tests

areusch commented on code in PR #11657:
URL: https://github.com/apache/tvm/pull/11657#discussion_r894843568


##########
tests/python/relay/aot/test_c_device_api.py:
##########
@@ -151,7 +158,7 @@ def test_device_api_hooks_unpacked_api(device_api_main_func):
     # We dont need to check exact input and output var names in this test.
     # Hence, using a regex to cover any legal I/O name.
     regex = re.compile(
-        'tir\.tvm_check_return\(0, -1, tir\.call_extern\("tvmgen_default_ethos_u_main_0", \w+, \w+, device_context_ethos_u\)\)'
+        r'tir\.tvm_check_return\(0, -1, tir\.call_extern\("tvmgen_default_ethos_u_main_0", \w+, \w+, device_context_ethos_u\)\)'  # pylint: disable=line-too-long

Review Comment:
   could you break this up rather than disabling? e.g.
   ```
   r'tir\.tvm_check_return\('
   r'0, -1, '
   r'tir\.call_extern\("tvmgen_default_ethos_u_main_0", '
   r'\w+, \w+, device_context_ethos_u\)\)'
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org