You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/21 07:20:39 UTC
[GitHub] [dolphinscheduler-sdk-python] jieguangzhou opened a new issue, #61: [impv] Auto check and add output local_params if we define the special grammar in the task definition
jieguangzhou opened a new issue, #61:
URL: https://github.com/apache/dolphinscheduler-sdk-python/issues/61
For example
If we define the shell task, and the command like this
```shell
task = Shell(name="example", command="${setValue(a=1)}")
```
Then we can auto add the output local_params `{"prop": "a", "direct": "OUT", "type": "VARCHAR", "value": ""}`
The Python, SQL, Procedure also can do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [impv] Auto check and add output local_params if we define the special grammar in the task definition [dolphinscheduler-sdk-python]
Posted by "HarshitNagpal29 (via GitHub)" <gi...@apache.org>.
HarshitNagpal29 commented on issue #61:
URL: https://github.com/apache/dolphinscheduler-sdk-python/issues/61#issuecomment-1895006461
@zhongjiajie Sir please assign this issue to me and brief me about the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [impv] Auto check and add output local_params if we define the special grammar in the task definition [dolphinscheduler-sdk-python]
Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie commented on issue #61:
URL: https://github.com/apache/dolphinscheduler-sdk-python/issues/61#issuecomment-1915868520
hi, @HarshitNagpal29 do not worry about that, handle your exams it more important thing. and
1. We have this parameter in our base class, and shell task inherit the base class, which you can see in https://github.com/apache/dolphinscheduler-sdk-python/blob/a7026dab2fb8443e66b72160b5a54977c3d07211/src/pydolphinscheduler/core/task.py#L169
2. the `setValue` is the keyword for dolphinschdudler,we use it to set output value in dolphinscheduler web ui, which you can see in https://dolphinscheduler.apache.org/en-us/docs/3.2.0/guide/parameter/context. As you can see, In web ui we have to do both `setValue` in the content of task definition, and add output parameter in `customer parameter` and set it as `out`. but I think we can just use `setValue` syntax in python sdk, then detect and set param by python sdk itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [impv] Auto check and add output local_params if we define the special grammar in the task definition [dolphinscheduler-sdk-python]
Posted by "HarshitNagpal29 (via GitHub)" <gi...@apache.org>.
HarshitNagpal29 commented on issue #61:
URL: https://github.com/apache/dolphinscheduler-sdk-python/issues/61#issuecomment-1910870139
@zhongjiajie Sir, sorry for the delayed response. My internal University exams were going on that's why I was not able to respond, sir I looked and I am finding it a bit difficult due to certain reasons:
1) The current Shell class has no explicit code for defining or managing output parameters.
2) Integration of setValue internally with task classes is kind of very confusing for me.
Can you please provide me with some hints on how to approach this problem ,I am feeling very overwhelmed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [impv] Auto check and add output local_params if we define the special grammar in the task definition [dolphinscheduler-sdk-python]
Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie commented on issue #61:
URL: https://github.com/apache/dolphinscheduler-sdk-python/issues/61#issuecomment-1895184911
currently, we have to explicitly declare the parameters that need to be set output, such as
```py
task = Shell(name="example", command="${setValue(a=1)}", output_params={
"a": "",
})
```
and this issue want to remove the param output_params in `Shell`,
```py
task = Shell(name="example", command="${setValue(a=1)}")
```
and we set in in pydolphinscheduler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org