You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Michael Fong <mc...@gmail.com> on 2017/08/22 12:30:46 UTC

mvn checkstyle error vs IDE based stylecheck

Hi, all,


I am new to this community and would like to make some contributions to
this awesome project.

While I was exploring the source code, I noticed there is a maven tests
that verify the checkstyle of java codes. Something like the following
would pop up after executing `mvn clean install` or `mvn verify`
################
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (validate) on
project flink-connector-cassandra_2.11: You have 112 Checkstyle violations.
-> [Help 1]
################

Would there there any IDE based checkstyle / auto-format that could assist
me for this purpose?  I currently use IntelliJ (the latest build) for most
of my development. I tried to to install the checkstyle rules instructed on
https://github.com/apache/flink/blob/master/docs/internals/ide_setup.md#intellij-idea,
but did not succeed.

Thanks in advance!

Sincerely,

Michael Fong

Re: mvn checkstyle error vs IDE based stylecheck

Posted by Michael Fong <mc...@gmail.com>.
Hi,

Thanks for pointing that out! It seems I must have misconfigured that step
earlier. Now it works flawlessly.

Thanks again!

Regards,

On Tue, Aug 22, 2017 at 9:37 PM, Chesnay Schepler <ch...@apache.org>
wrote:

> Did you do step 4 "Select /6.19/ in the “Checkstyle Version” dropdown and
> click apply.*"?
> *
> On 22.08.2017 14:53, Michael Fong wrote:
>
>> Hi,
>>
>> Thanks to your swift reply.
>>
>> IntelliJ complains about checkstyle rules with the following exception:
>>
>> org.infernus.idea.checkstyle.exception.CheckStylePluginException:
>> <html><b>The Checkstyle rules file could not be
>> parsed.</b><br>SuppressionCommentFilter is not allowed as a child in
>> Checker<br>The file has been blacklisted for 60s.</html>
>> at org.infernus.idea.checkstyle.checker.CheckerFactory.blacklis
>> tAndShowMessage(CheckerFactory.java:197)
>> at org.infernus.idea.checkstyle.checker.CheckerFactory.blacklis
>> tAndShowMessage(CheckerFactory.java:213)
>> at org.infernus.idea.checkstyle.checker.CheckerFactory.createCh
>> ecker(CheckerFactory.java:145)
>> at org.infernus.idea.checkstyle.checker.CheckerFactory.getOrCre
>> ateCachedChecker(CheckerFactory.java:75)
>> at org.infernus.idea.checkstyle.checker.CheckerFactory.checker(
>> CheckerFactory.java:57)
>>       ...
>>
>> Thanks!
>>
>> Attached the screenshot, hope this would help.
>> Inline image 1
>>
>> On Tue, Aug 22, 2017 at 8:41 PM, Chesnay Schepler <chesnay@apache.org
>> <ma...@apache.org>> wrote:
>>
>>     The IDE setup guide you tried is what most people i know are using.
>>
>>     Can you tell us how these didn't work for you?
>>
>>
>>     On 22.08.2017 14 <tel:22.08.2017%2014>:30, Michael Fong wrote:
>>
>>         Hi, all,
>>
>>
>>         I am new to this community and would like to make some
>>         contributions to
>>         this awesome project.
>>
>>         While I was exploring the source code, I noticed there is a
>>         maven tests
>>         that verify the checkstyle of java codes. Something like the
>>         following
>>         would pop up after executing `mvn clean install` or `mvn verify`
>>         ################
>>         [ERROR] Failed to execute goal
>>         org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check
>>         (validate) on
>>         project flink-connector-cassandra_2.11: You have 112
>>         Checkstyle violations.
>>         -> [Help 1]
>>         ################
>>
>>         Would there there any IDE based checkstyle / auto-format that
>>         could assist
>>         me for this purpose?  I currently use IntelliJ (the latest
>>         build) for most
>>         of my development. I tried to to install the checkstyle rules
>>         instructed on
>>         https://github.com/apache/flink/blob/master/docs/internals/
>> ide_setup.md#intellij-idea
>>         <https://github.com/apache/flink/blob/master/docs/internals/
>> ide_setup.md#intellij-idea>,
>>         but did not succeed.
>>
>>         Thanks in advance!
>>
>>         Sincerely,
>>
>>         Michael Fong
>>
>>
>>
>>
>

Re: mvn checkstyle error vs IDE based stylecheck

Posted by Chesnay Schepler <ch...@apache.org>.
Did you do step 4 "Select /6.19/ in the “Checkstyle Version” dropdown 
and click apply.*"?
*
On 22.08.2017 14:53, Michael Fong wrote:
> Hi,
>
> Thanks to your swift reply.
>
> IntelliJ complains about checkstyle rules with the following exception:
>
> org.infernus.idea.checkstyle.exception.CheckStylePluginException: 
> <html><b>The Checkstyle rules file could not be 
> parsed.</b><br>SuppressionCommentFilter is not allowed as a child in 
> Checker<br>The file has been blacklisted for 60s.</html>
> at 
> org.infernus.idea.checkstyle.checker.CheckerFactory.blacklistAndShowMessage(CheckerFactory.java:197)
> at 
> org.infernus.idea.checkstyle.checker.CheckerFactory.blacklistAndShowMessage(CheckerFactory.java:213)
> at 
> org.infernus.idea.checkstyle.checker.CheckerFactory.createChecker(CheckerFactory.java:145)
> at 
> org.infernus.idea.checkstyle.checker.CheckerFactory.getOrCreateCachedChecker(CheckerFactory.java:75)
> at 
> org.infernus.idea.checkstyle.checker.CheckerFactory.checker(CheckerFactory.java:57)
>       ...
>
> Thanks!
>
> Attached the screenshot, hope this would help.
> Inline image 1
>
> On Tue, Aug 22, 2017 at 8:41 PM, Chesnay Schepler <chesnay@apache.org 
> <ma...@apache.org>> wrote:
>
>     The IDE setup guide you tried is what most people i know are using.
>
>     Can you tell us how these didn't work for you?
>
>
>     On 22.08.2017 14 <tel:22.08.2017%2014>:30, Michael Fong wrote:
>
>         Hi, all,
>
>
>         I am new to this community and would like to make some
>         contributions to
>         this awesome project.
>
>         While I was exploring the source code, I noticed there is a
>         maven tests
>         that verify the checkstyle of java codes. Something like the
>         following
>         would pop up after executing `mvn clean install` or `mvn verify`
>         ################
>         [ERROR] Failed to execute goal
>         org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check
>         (validate) on
>         project flink-connector-cassandra_2.11: You have 112
>         Checkstyle violations.
>         -> [Help 1]
>         ################
>
>         Would there there any IDE based checkstyle / auto-format that
>         could assist
>         me for this purpose?  I currently use IntelliJ (the latest
>         build) for most
>         of my development. I tried to to install the checkstyle rules
>         instructed on
>         https://github.com/apache/flink/blob/master/docs/internals/ide_setup.md#intellij-idea
>         <https://github.com/apache/flink/blob/master/docs/internals/ide_setup.md#intellij-idea>,
>         but did not succeed.
>
>         Thanks in advance!
>
>         Sincerely,
>
>         Michael Fong
>
>
>


Re: mvn checkstyle error vs IDE based stylecheck

Posted by Michael Fong <mc...@gmail.com>.
Hi,

Thanks to your swift reply.

IntelliJ complains about checkstyle rules with the following exception:

org.infernus.idea.checkstyle.exception.CheckStylePluginException:
<html><b>The Checkstyle rules file could not be
parsed.</b><br>SuppressionCommentFilter is not allowed as a child in
Checker<br>The file has been blacklisted for 60s.</html>
at
org.infernus.idea.checkstyle.checker.CheckerFactory.blacklistAndShowMessage(CheckerFactory.java:197)
at
org.infernus.idea.checkstyle.checker.CheckerFactory.blacklistAndShowMessage(CheckerFactory.java:213)
at
org.infernus.idea.checkstyle.checker.CheckerFactory.createChecker(CheckerFactory.java:145)
at
org.infernus.idea.checkstyle.checker.CheckerFactory.getOrCreateCachedChecker(CheckerFactory.java:75)
at
org.infernus.idea.checkstyle.checker.CheckerFactory.checker(CheckerFactory.java:57)
      ...

Thanks!

Attached the screenshot, hope this would help.
[image: Inline image 1]

On Tue, Aug 22, 2017 at 8:41 PM, Chesnay Schepler <ch...@apache.org>
wrote:

> The IDE setup guide you tried is what most people i know are using.
>
> Can you tell us how these didn't work for you?
>
>
> On 22.08.2017 14:30, Michael Fong wrote:
>
>> Hi, all,
>>
>>
>> I am new to this community and would like to make some contributions to
>> this awesome project.
>>
>> While I was exploring the source code, I noticed there is a maven tests
>> that verify the checkstyle of java codes. Something like the following
>> would pop up after executing `mvn clean install` or `mvn verify`
>> ################
>> [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (validate) on
>> project flink-connector-cassandra_2.11: You have 112 Checkstyle
>> violations.
>> -> [Help 1]
>> ################
>>
>> Would there there any IDE based checkstyle / auto-format that could assist
>> me for this purpose?  I currently use IntelliJ (the latest build) for most
>> of my development. I tried to to install the checkstyle rules instructed
>> on
>> https://github.com/apache/flink/blob/master/docs/internals/
>> ide_setup.md#intellij-idea,
>> but did not succeed.
>>
>> Thanks in advance!
>>
>> Sincerely,
>>
>> Michael Fong
>>
>>
>

Re: mvn checkstyle error vs IDE based stylecheck

Posted by Chesnay Schepler <ch...@apache.org>.
The IDE setup guide you tried is what most people i know are using.

Can you tell us how these didn't work for you?

On 22.08.2017 14:30, Michael Fong wrote:
> Hi, all,
>
>
> I am new to this community and would like to make some contributions to
> this awesome project.
>
> While I was exploring the source code, I noticed there is a maven tests
> that verify the checkstyle of java codes. Something like the following
> would pop up after executing `mvn clean install` or `mvn verify`
> ################
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (validate) on
> project flink-connector-cassandra_2.11: You have 112 Checkstyle violations.
> -> [Help 1]
> ################
>
> Would there there any IDE based checkstyle / auto-format that could assist
> me for this purpose?  I currently use IntelliJ (the latest build) for most
> of my development. I tried to to install the checkstyle rules instructed on
> https://github.com/apache/flink/blob/master/docs/internals/ide_setup.md#intellij-idea,
> but did not succeed.
>
> Thanks in advance!
>
> Sincerely,
>
> Michael Fong
>