You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Luke Cwik <lc...@google.com> on 2020/02/22 00:38:01 UTC
[VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252
Please review the release of the following artifacts that we vendor:
* beam-vendor-grpc-1_26_0
Hi everyone,
Please review and vote on the release candidate #1 for the version 0.2, as
follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which includes:
* the official Apache source release to be deployed to dist.apache.org [1],
which is signed with the key with
fingerprint EAD5DE293F4A03DD2E77565589E68A56E371CCA2 [2],
* all artifacts to be deployed to the Maven Central Repository [3],
* commit hash "91125d1d1fc1fe8c5684a486c9b6163c4ec41549" [4],
The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.
Thanks,
Release Manager
[1] https://dist.apache.org/repos/dist/dev/beam/vendor/
[2] https://dist.apache.org/repos/dist/release/beam/KEYS
[3] https://repository.apache.org/content/repositories/orgapachebeam-1092/
[4]
https://github.com/apache/beam/commit/91125d1d1fc1fe8c5684a486c9b6163c4ec41549
[RESULT] [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252
Posted by Luke Cwik <lc...@google.com>.
I'm happy to announce that we have unanimously approved this release.
There are 7 approving votes, 4 of which are binding:
* Ismaël Mejía
* Robert Bradshaw
* Ahmet Altay
* Luke Cwik
There are no disapproving votes.
Thanks everyone!
On Sat, Feb 22, 2020 at 5:49 AM Ismaël Mejía <ie...@gmail.com> wrote:
> +1 (binding)
>
> Verified signatures, produced jar from code and checked that artifact does
> not contain both Main.class and module-info.classes
>
> Thanks for taking care of this Tomo and Luke.
>
>
> On Sat, Feb 22, 2020 at 10:27 AM jincheng sun <su...@gmail.com>
> wrote:
>
>> +1(non-binding)
>>
>> Best,
>> Jincheng
>>
>>
>> Kai Jiang <ji...@gmail.com> 于2020年2月22日周六 下午2:58写道：
>>
>>> +1 (non-binding)
>>>
>>> On Fri, Feb 21, 2020 at 5:03 PM Robin Qiu <ro...@google.com> wrote:
>>>
>>>> +1 (verified)
>>>>
>>>> On Fri, Feb 21, 2020 at 4:55 PM Robert Bradshaw <ro...@google.com>
>>>> wrote:
>>>>
>>>>> +1 (binding)
>>>>>
>>>>>
>>>>> On Fri, Feb 21, 2020 at 4:48 PM Ahmet Altay <al...@google.com> wrote:
>>>>> >
>>>>> > +1
>>>>> >
>>>>> > On Fri, Feb 21, 2020 at 4:39 PM Luke Cwik <lc...@google.com> wrote:
>>>>> >>
>>>>> >> +1 (binding)
>>>>> >> I diffed the binary contents of the 0.1 jar and 0.2 jar with no
>>>>> changes to the contents of the files and can confirm that module-info.class
>>>>> the offending Main.class and Main$1.class have been removed as well.
>>>>> >>
>>>>> >> On Fri, Feb 21, 2020 at 4:38 PM Luke Cwik <lc...@google.com> wrote:
>>>>> >>>
>>>>> >>> Please review the release of the following artifacts that we
>>>>> vendor:
>>>>> >>> * beam-vendor-grpc-1_26_0
>>>>> >>>
>>>>> >>> Hi everyone,
>>>>> >>> Please review and vote on the release candidate #1 for the version
>>>>> 0.2, as follows:
>>>>> >>> [ ] +1, Approve the release
>>>>> >>> [ ] -1, Do not approve the release (please provide specific
>>>>> comments)
>>>>> >>>
>>>>> >>>
>>>>> >>> The complete staging area is available for your review, which
>>>>> includes:
>>>>> >>> * the official Apache source release to be deployed to
>>>>> dist.apache.org [1], which is signed with the key with fingerprint
>>>>> EAD5DE293F4A03DD2E77565589E68A56E371CCA2 [2],
>>>>> >>> * all artifacts to be deployed to the Maven Central Repository [3],
>>>>> >>> * commit hash "91125d1d1fc1fe8c5684a486c9b6163c4ec41549" [4],
>>>>> >>>
>>>>> >>> The vote will be open for at least 72 hours. It is adopted by
>>>>> majority approval, with at least 3 PMC affirmative votes.
>>>>> >>>
>>>>> >>> Thanks,
>>>>> >>> Release Manager
>>>>> >>>
>>>>> >>> [1] https://dist.apache.org/repos/dist/dev/beam/vendor/
>>>>> >>> [2] https://dist.apache.org/repos/dist/release/beam/KEYS
>>>>> >>> [3]
>>>>> https://repository.apache.org/content/repositories/orgapachebeam-1092/
>>>>> >>> [4]
>>>>> https://github.com/apache/beam/commit/91125d1d1fc1fe8c5684a486c9b6163c4ec41549
>>>>>
>>>> ᐧ
>>>
>>
Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252
Posted by Ismaël Mejía <ie...@gmail.com>.
+1 (binding)
Verified signatures, produced jar from code and checked that artifact does
not contain both Main.class and module-info.classes
Thanks for taking care of this Tomo and Luke.
On Sat, Feb 22, 2020 at 10:27 AM jincheng sun <su...@gmail.com>
wrote:
> +1(non-binding)
>
> Best,
> Jincheng
>
>
> Kai Jiang <ji...@gmail.com> 于2020年2月22日周六 下午2:58写道：
>
>> +1 (non-binding)
>>
>> On Fri, Feb 21, 2020 at 5:03 PM Robin Qiu <ro...@google.com> wrote:
>>
>>> +1 (verified)
>>>
>>> On Fri, Feb 21, 2020 at 4:55 PM Robert Bradshaw <ro...@google.com>
>>> wrote:
>>>
>>>> +1 (binding)
>>>>
>>>>
>>>> On Fri, Feb 21, 2020 at 4:48 PM Ahmet Altay <al...@google.com> wrote:
>>>> >
>>>> > +1
>>>> >
>>>> > On Fri, Feb 21, 2020 at 4:39 PM Luke Cwik <lc...@google.com> wrote:
>>>> >>
>>>> >> +1 (binding)
>>>> >> I diffed the binary contents of the 0.1 jar and 0.2 jar with no
>>>> changes to the contents of the files and can confirm that module-info.class
>>>> the offending Main.class and Main$1.class have been removed as well.
>>>> >>
>>>> >> On Fri, Feb 21, 2020 at 4:38 PM Luke Cwik <lc...@google.com> wrote:
>>>> >>>
>>>> >>> Please review the release of the following artifacts that we vendor:
>>>> >>> * beam-vendor-grpc-1_26_0
>>>> >>>
>>>> >>> Hi everyone,
>>>> >>> Please review and vote on the release candidate #1 for the version
>>>> 0.2, as follows:
>>>> >>> [ ] +1, Approve the release
>>>> >>> [ ] -1, Do not approve the release (please provide specific
>>>> comments)
>>>> >>>
>>>> >>>
>>>> >>> The complete staging area is available for your review, which
>>>> includes:
>>>> >>> * the official Apache source release to be deployed to
>>>> dist.apache.org [1], which is signed with the key with fingerprint
>>>> EAD5DE293F4A03DD2E77565589E68A56E371CCA2 [2],
>>>> >>> * all artifacts to be deployed to the Maven Central Repository [3],
>>>> >>> * commit hash "91125d1d1fc1fe8c5684a486c9b6163c4ec41549" [4],
>>>> >>>
>>>> >>> The vote will be open for at least 72 hours. It is adopted by
>>>> majority approval, with at least 3 PMC affirmative votes.
>>>> >>>
>>>> >>> Thanks,
>>>> >>> Release Manager
>>>> >>>
>>>> >>> [1] https://dist.apache.org/repos/dist/dev/beam/vendor/
>>>> >>> [2] https://dist.apache.org/repos/dist/release/beam/KEYS
>>>> >>> [3]
>>>> https://repository.apache.org/content/repositories/orgapachebeam-1092/
>>>> >>> [4]
>>>> https://github.com/apache/beam/commit/91125d1d1fc1fe8c5684a486c9b6163c4ec41549
>>>>
>>> ᐧ
>>
>
Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252
Posted by jincheng sun <su...@gmail.com>.
+1(non-binding)
Best,
Jincheng
Kai Jiang <ji...@gmail.com> 于2020年2月22日周六 下午2:58写道：
> +1 (non-binding)
>
> On Fri, Feb 21, 2020 at 5:03 PM Robin Qiu <ro...@google.com> wrote:
>
>> +1 (verified)
>>
>> On Fri, Feb 21, 2020 at 4:55 PM Robert Bradshaw <ro...@google.com>
>> wrote:
>>
>>> +1 (binding)
>>>
>>>
>>> On Fri, Feb 21, 2020 at 4:48 PM Ahmet Altay <al...@google.com> wrote:
>>> >
>>> > +1
>>> >
>>> > On Fri, Feb 21, 2020 at 4:39 PM Luke Cwik <lc...@google.com> wrote:
>>> >>
>>> >> +1 (binding)
>>> >> I diffed the binary contents of the 0.1 jar and 0.2 jar with no
>>> changes to the contents of the files and can confirm that module-info.class
>>> the offending Main.class and Main$1.class have been removed as well.
>>> >>
>>> >> On Fri, Feb 21, 2020 at 4:38 PM Luke Cwik <lc...@google.com> wrote:
>>> >>>
>>> >>> Please review the release of the following artifacts that we vendor:
>>> >>> * beam-vendor-grpc-1_26_0
>>> >>>
>>> >>> Hi everyone,
>>> >>> Please review and vote on the release candidate #1 for the version
>>> 0.2, as follows:
>>> >>> [ ] +1, Approve the release
>>> >>> [ ] -1, Do not approve the release (please provide specific comments)
>>> >>>
>>> >>>
>>> >>> The complete staging area is available for your review, which
>>> includes:
>>> >>> * the official Apache source release to be deployed to
>>> dist.apache.org [1], which is signed with the key with fingerprint
>>> EAD5DE293F4A03DD2E77565589E68A56E371CCA2 [2],
>>> >>> * all artifacts to be deployed to the Maven Central Repository [3],
>>> >>> * commit hash "91125d1d1fc1fe8c5684a486c9b6163c4ec41549" [4],
>>> >>>
>>> >>> The vote will be open for at least 72 hours. It is adopted by
>>> majority approval, with at least 3 PMC affirmative votes.
>>> >>>
>>> >>> Thanks,
>>> >>> Release Manager
>>> >>>
>>> >>> [1] https://dist.apache.org/repos/dist/dev/beam/vendor/
>>> >>> [2] https://dist.apache.org/repos/dist/release/beam/KEYS
>>> >>> [3]
>>> https://repository.apache.org/content/repositories/orgapachebeam-1092/
>>> >>> [4]
>>> https://github.com/apache/beam/commit/91125d1d1fc1fe8c5684a486c9b6163c4ec41549
>>>
>> ᐧ
>
Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252
Posted by Kai Jiang <ji...@gmail.com>.
+1 (non-binding)
On Fri, Feb 21, 2020 at 5:03 PM Robin Qiu <ro...@google.com> wrote:
> +1 (verified)
>
> On Fri, Feb 21, 2020 at 4:55 PM Robert Bradshaw <ro...@google.com>
> wrote:
>
>> +1 (binding)
>>
>>
>> On Fri, Feb 21, 2020 at 4:48 PM Ahmet Altay <al...@google.com> wrote:
>> >
>> > +1
>> >
>> > On Fri, Feb 21, 2020 at 4:39 PM Luke Cwik <lc...@google.com> wrote:
>> >>
>> >> +1 (binding)
>> >> I diffed the binary contents of the 0.1 jar and 0.2 jar with no
>> changes to the contents of the files and can confirm that module-info.class
>> the offending Main.class and Main$1.class have been removed as well.
>> >>
>> >> On Fri, Feb 21, 2020 at 4:38 PM Luke Cwik <lc...@google.com> wrote:
>> >>>
>> >>> Please review the release of the following artifacts that we vendor:
>> >>> * beam-vendor-grpc-1_26_0
>> >>>
>> >>> Hi everyone,
>> >>> Please review and vote on the release candidate #1 for the version
>> 0.2, as follows:
>> >>> [ ] +1, Approve the release
>> >>> [ ] -1, Do not approve the release (please provide specific comments)
>> >>>
>> >>>
>> >>> The complete staging area is available for your review, which
>> includes:
>> >>> * the official Apache source release to be deployed to
>> dist.apache.org [1], which is signed with the key with fingerprint
>> EAD5DE293F4A03DD2E77565589E68A56E371CCA2 [2],
>> >>> * all artifacts to be deployed to the Maven Central Repository [3],
>> >>> * commit hash "91125d1d1fc1fe8c5684a486c9b6163c4ec41549" [4],
>> >>>
>> >>> The vote will be open for at least 72 hours. It is adopted by
>> majority approval, with at least 3 PMC affirmative votes.
>> >>>
>> >>> Thanks,
>> >>> Release Manager
>> >>>
>> >>> [1] https://dist.apache.org/repos/dist/dev/beam/vendor/
>> >>> [2] https://dist.apache.org/repos/dist/release/beam/KEYS
>> >>> [3]
>> https://repository.apache.org/content/repositories/orgapachebeam-1092/
>> >>> [4]
>> https://github.com/apache/beam/commit/91125d1d1fc1fe8c5684a486c9b6163c4ec41549
>>
> ᐧ
Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252
Posted by Robin Qiu <ro...@google.com>.
+1 (verified)
On Fri, Feb 21, 2020 at 4:55 PM Robert Bradshaw <ro...@google.com> wrote:
> +1 (binding)
>
>
> On Fri, Feb 21, 2020 at 4:48 PM Ahmet Altay <al...@google.com> wrote:
> >
> > +1
> >
> > On Fri, Feb 21, 2020 at 4:39 PM Luke Cwik <lc...@google.com> wrote:
> >>
> >> +1 (binding)
> >> I diffed the binary contents of the 0.1 jar and 0.2 jar with no changes
> to the contents of the files and can confirm that module-info.class the
> offending Main.class and Main$1.class have been removed as well.
> >>
> >> On Fri, Feb 21, 2020 at 4:38 PM Luke Cwik <lc...@google.com> wrote:
> >>>
> >>> Please review the release of the following artifacts that we vendor:
> >>> * beam-vendor-grpc-1_26_0
> >>>
> >>> Hi everyone,
> >>> Please review and vote on the release candidate #1 for the version
> 0.2, as follows:
> >>> [ ] +1, Approve the release
> >>> [ ] -1, Do not approve the release (please provide specific comments)
> >>>
> >>>
> >>> The complete staging area is available for your review, which includes:
> >>> * the official Apache source release to be deployed to dist.apache.org
> [1], which is signed with the key with fingerprint
> EAD5DE293F4A03DD2E77565589E68A56E371CCA2 [2],
> >>> * all artifacts to be deployed to the Maven Central Repository [3],
> >>> * commit hash "91125d1d1fc1fe8c5684a486c9b6163c4ec41549" [4],
> >>>
> >>> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
> >>>
> >>> Thanks,
> >>> Release Manager
> >>>
> >>> [1] https://dist.apache.org/repos/dist/dev/beam/vendor/
> >>> [2] https://dist.apache.org/repos/dist/release/beam/KEYS
> >>> [3]
> https://repository.apache.org/content/repositories/orgapachebeam-1092/
> >>> [4]
> https://github.com/apache/beam/commit/91125d1d1fc1fe8c5684a486c9b6163c4ec41549
>
Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252
Posted by Robert Bradshaw <ro...@google.com>.
+1 (binding)
On Fri, Feb 21, 2020 at 4:48 PM Ahmet Altay <al...@google.com> wrote:
>
> +1
>
> On Fri, Feb 21, 2020 at 4:39 PM Luke Cwik <lc...@google.com> wrote:
>>
>> +1 (binding)
>> I diffed the binary contents of the 0.1 jar and 0.2 jar with no changes to the contents of the files and can confirm that module-info.class the offending Main.class and Main$1.class have been removed as well.
>>
>> On Fri, Feb 21, 2020 at 4:38 PM Luke Cwik <lc...@google.com> wrote:
>>>
>>> Please review the release of the following artifacts that we vendor:
>>> * beam-vendor-grpc-1_26_0
>>>
>>> Hi everyone,
>>> Please review and vote on the release candidate #1 for the version 0.2, as follows:
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>
>>>
>>> The complete staging area is available for your review, which includes:
>>> * the official Apache source release to be deployed to dist.apache.org [1], which is signed with the key with fingerprint EAD5DE293F4A03DD2E77565589E68A56E371CCA2 [2],
>>> * all artifacts to be deployed to the Maven Central Repository [3],
>>> * commit hash "91125d1d1fc1fe8c5684a486c9b6163c4ec41549" [4],
>>>
>>> The vote will be open for at least 72 hours. It is adopted by majority approval, with at least 3 PMC affirmative votes.
>>>
>>> Thanks,
>>> Release Manager
>>>
>>> [1] https://dist.apache.org/repos/dist/dev/beam/vendor/
>>> [2] https://dist.apache.org/repos/dist/release/beam/KEYS
>>> [3] https://repository.apache.org/content/repositories/orgapachebeam-1092/
>>> [4] https://github.com/apache/beam/commit/91125d1d1fc1fe8c5684a486c9b6163c4ec41549
Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252
Posted by Ahmet Altay <al...@google.com>.
+1
On Fri, Feb 21, 2020 at 4:39 PM Luke Cwik <lc...@google.com> wrote:
> +1 (binding)
> I diffed the binary contents of the 0.1 jar and 0.2 jar with no changes to
> the contents of the files and can confirm that module-info.class the
> offending Main.class and Main$1.class have been removed as well.
>
> On Fri, Feb 21, 2020 at 4:38 PM Luke Cwik <lc...@google.com> wrote:
>
>> Please review the release of the following artifacts that we vendor:
>> * beam-vendor-grpc-1_26_0
>>
>> Hi everyone,
>> Please review and vote on the release candidate #1 for the version 0.2,
>> as follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>>
>>
>> The complete staging area is available for your review, which includes:
>> * the official Apache source release to be deployed to dist.apache.org [1],
>> which is signed with the key with
>> fingerprint EAD5DE293F4A03DD2E77565589E68A56E371CCA2 [2],
>> * all artifacts to be deployed to the Maven Central Repository [3],
>> * commit hash "91125d1d1fc1fe8c5684a486c9b6163c4ec41549" [4],
>>
>> The vote will be open for at least 72 hours. It is adopted by majority
>> approval, with at least 3 PMC affirmative votes.
>>
>> Thanks,
>> Release Manager
>>
>> [1] https://dist.apache.org/repos/dist/dev/beam/vendor/
>> [2] https://dist.apache.org/repos/dist/release/beam/KEYS
>> [3]
>> https://repository.apache.org/content/repositories/orgapachebeam-1092/
>> [4]
>> https://github.com/apache/beam/commit/91125d1d1fc1fe8c5684a486c9b6163c4ec41549
>>
>
Re: [VOTE] Vendored Dependencies Release gRPC 1.26.0 v0.2 for BEAM-9252
Posted by Luke Cwik <lc...@google.com>.
+1 (binding)
I diffed the binary contents of the 0.1 jar and 0.2 jar with no changes to
the contents of the files and can confirm that module-info.class the
offending Main.class and Main$1.class have been removed as well.
On Fri, Feb 21, 2020 at 4:38 PM Luke Cwik <lc...@google.com> wrote:
> Please review the release of the following artifacts that we vendor:
> * beam-vendor-grpc-1_26_0
>
> Hi everyone,
> Please review and vote on the release candidate #1 for the version 0.2, as
> follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
>
> The complete staging area is available for your review, which includes:
> * the official Apache source release to be deployed to dist.apache.org [1],
> which is signed with the key with
> fingerprint EAD5DE293F4A03DD2E77565589E68A56E371CCA2 [2],
> * all artifacts to be deployed to the Maven Central Repository [3],
> * commit hash "91125d1d1fc1fe8c5684a486c9b6163c4ec41549" [4],
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Release Manager
>
> [1] https://dist.apache.org/repos/dist/dev/beam/vendor/
> [2] https://dist.apache.org/repos/dist/release/beam/KEYS
> [3] https://repository.apache.org/content/repositories/orgapachebeam-1092/
> [4]
> https://github.com/apache/beam/commit/91125d1d1fc1fe8c5684a486c9b6163c4ec41549
>