You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Eric Gillespie <ep...@pretzelnet.org> on 2004/07/14 15:54:30 UTC
[PATCH] Default to fsfs when not built with Berkeley DB
I have built for the first time without bdb support. If you
build this way, svnadmin create has a useless default and cries:
svn: Unknown FS type 'bdb'
I think it would be good to fix this for 1.1 since it's so
trivial :). Can i commit the following patch to trunk?
When configured without Berkeley DB, make libsvn_fs default to
the fsfs back-end.
* configure.in:
Set DEFAULT_FS_TYPE to "bdb" if configured with Berkeley DB, or
"fsfs" if not. Publish this to svn_private_config.h with
AC_DEFINE_UNQUOTED.
* subversion/libsvn_fs/fs-loader.c:
Don't define DEFAULT_FS_TYPE here; expect it to come from
svn_private_config.h.
Index: configure.in
===================================================================
--- configure.in (revision 10284)
+++ configure.in (working copy)
@@ -327,6 +327,9 @@
INSTALL_STATIC_RULES="$INSTALL_STATIC_RULES install-bdb-lib"
BDB_TEST_DEPS="\$(BDB_TEST_DEPS)"
BDB_TEST_PROGRAMS="\$(BDB_TEST_PROGRAMS)"
+ DEFAULT_FS_TYPE="bdb"
+else
+ DEFAULT_FS_TYPE="fsfs"
fi
if test "$svn_lib_neon" = "yes"; then
@@ -352,6 +355,8 @@
[The desired minor version for the Berkeley DB])
AC_DEFINE_UNQUOTED(SVN_FS_WANT_DB_PATCH, $SVN_FS_WANT_DB_PATCH,
[The desired patch version for the Berkeley DB])
+AC_DEFINE_UNQUOTED(DEFAULT_FS_TYPE, "$DEFAULT_FS_TYPE",
+ [The fs type to use by default])
dnl Check for header files ----------------
Index: subversion/libsvn_fs/fs-loader.c
===================================================================
--- subversion/libsvn_fs/fs-loader.c (revision 10284)
+++ subversion/libsvn_fs/fs-loader.c (working copy)
@@ -31,7 +31,6 @@
#include "fs-loader.h"
-#define DEFAULT_FS_TYPE "bdb"
#define FS_TYPE_FILENAME "fs-type"
/* The implementation of this library is deliberately not separated
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Default to fsfs when not built with Berkeley DB
Posted by Ben Reser <be...@reser.org>.
On Wed, Jul 14, 2004 at 11:54:30AM -0400, Eric Gillespie wrote:
> I have built for the first time without bdb support. If you
> build this way, svnadmin create has a useless default and cries:
>
> svn: Unknown FS type 'bdb'
>
> I think it would be good to fix this for 1.1 since it's so
> trivial :). Can i commit the following patch to trunk?
>
>
>
> When configured without Berkeley DB, make libsvn_fs default to
> the fsfs back-end.
>
> * configure.in:
> Set DEFAULT_FS_TYPE to "bdb" if configured with Berkeley DB, or
> "fsfs" if not. Publish this to svn_private_config.h with
> AC_DEFINE_UNQUOTED.
>
> * subversion/libsvn_fs/fs-loader.c:
> Don't define DEFAULT_FS_TYPE here; expect it to come from
> svn_private_config.h.
+1 from me.
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Default to fsfs when not built with Berkeley DB
Posted by Andy Whitcroft <ap...@shadowen.org>.
--On 14 July 2004 12:18 -0400 Eric Gillespie <ep...@pretzelnet.org> wrote:
> Greg Hudson <gh...@MIT.EDU> writes:
>
>> The patch looks good technically. I didn't do this originally
>> because I thought it might bother other developers for svn to
>> silently use a new and unfamiliar repository format in this
>> situation, so you might give people a chance to object.
>
> Yeah, i will wait for more comment. I think this is a non-issue
> however. The configure script still whines quite loudly about
> the absence of Berkeley DB. And if they grab someone else's
> binaries, it's out of our hands anyway.
I would say that it would be nice if svnadmin were to give you some
indication of the default type, perhaps as part of the svnadmin create
--help command. Especially as creation of a repo is a silent matter.
-apw
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Default to fsfs when not built with Berkeley DB
Posted by kf...@collab.net.
Eric Gillespie <ep...@pretzelnet.org> writes:
> Greg Hudson <gh...@MIT.EDU> writes:
> > The patch looks good technically. I didn't do this originally
> > because I thought it might bother other developers for svn to
> > silently use a new and unfamiliar repository format in this
> > situation, so you might give people a chance to object.
>
> Yeah, i will wait for more comment. I think this is a non-issue
> however. The configure script still whines quite loudly about
> the absence of Berkeley DB. And if they grab someone else's
> binaries, it's out of our hands anyway.
+1 on this change. I most certainly do not object :-).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Default to fsfs when not built with Berkeley DB
Posted by Eric Gillespie <ep...@pretzelnet.org>.
Greg Hudson <gh...@MIT.EDU> writes:
> The patch looks good technically. I didn't do this originally
> because I thought it might bother other developers for svn to
> silently use a new and unfamiliar repository format in this
> situation, so you might give people a chance to object.
Yeah, i will wait for more comment. I think this is a non-issue
however. The configure script still whines quite loudly about
the absence of Berkeley DB. And if they grab someone else's
binaries, it's out of our hands anyway.
--
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Default to fsfs when not built with Berkeley DB
Posted by Greg Hudson <gh...@MIT.EDU>.
On Wed, 2004-07-14 at 11:54, Eric Gillespie wrote:
> I have built for the first time without bdb support. If you
> build this way, svnadmin create has a useless default and cries:
>
> svn: Unknown FS type 'bdb'
>
> I think it would be good to fix this for 1.1 since it's so
> trivial :). Can i commit the following patch to trunk?
The patch looks good technically. I didn't do this originally because I
thought it might bother other developers for svn to silently use a new
and unfamiliar repository format in this situation, so you might give
people a chance to object.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Default to fsfs when not built with Berkeley DB
Posted by Mark Phippard <Ma...@softlanding.com>.
epg@gould.diplodocus.org wrote on 07/14/2004 11:54:30 AM:
> I have built for the first time without bdb support. If you
> build this way, svnadmin create has a useless default and cries:
>
> svn: Unknown FS type 'bdb'
>
> I think it would be good to fix this for 1.1 since it's so
> trivial :). Can i commit the following patch to trunk?
>
FWIW, I think this would be a great enhancement!
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org