You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "killme2008 (via GitHub)" <gi...@apache.org> on 2023/04/23 13:49:06 UTC

[GitHub] [incubator-opendal] killme2008 commented on a diff in pull request #2089: chore: improve LoggingLayer docs and pub use log::Level

killme2008 commented on code in PR #2089:
URL: https://github.com/apache/incubator-opendal/pull/2089#discussion_r1174584784


##########
core/src/layers/logging.rs:
##########
@@ -27,7 +27,7 @@ use futures::TryFutureExt;
 use log::debug;
 use log::log;
 use log::trace;
-use log::Level;
+pub use log::Level;

Review Comment:
   Why? Or I think providing a `Level` wrapper in opendal would be good. The user just want to configure the logging level, but they have to add a new crate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org