[GitHub] [zookeeper] kelloggm commented on pull request #1638: ZOOKEEPER-4246: Resource leaks in org.apache.zookeeper.server.persistence.SnapStream#getInputStream and #getOutputStream

[GitBox <gi...@apache.org>]

kelloggm commented on pull request #1638:
URL: https://github.com/apache/zookeeper/pull/1638#issuecomment-809575037


   @maoling Sorry for the confusion. You asked:
   
   > Could you please show us how the error-prone complain about this?
   
   in reference to my comment:
   
   > I noticed the first because of the use of the error-prone GZIPOutputStream, and the other two after looking at the surrounding code.
   
   In this comment, I'm using "error-prone" as an [adjective](https://en.wiktionary.org/wiki/error-prone) - i.e. I'm saying that I think GZIPOutputStream is easy to use incorrectly. I did not intend to refer to [error-prone](https://github.com/google/error-prone), Google's code analysis tool. From your comment, it sounds like you understood me to mean that tool - sorry for the confusion! As far as I'm aware, that tool cannot find this bug, but I haven't run it on this code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org