[jira] [Updated] (SOLR-6090) Fix unreachable printLayout usage in cloud test

["Cao Manh Dat (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Cao Manh Dat updated SOLR-6090:
-------------------------------
    Attachment: SOLR-6090.patch

This patch delete some places that have above boilerplate code.

> Fix unreachable printLayout usage in cloud test
> -----------------------------------------------
>
>                 Key: SOLR-6090
>                 URL: https://issues.apache.org/jira/browse/SOLR-6090
>             Project: Solr
>          Issue Type: Task
>          Components: SolrCloud, Tests
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Cao Manh Dat
>            Priority: Minor
>             Fix For: 4.9, 6.0
>
>         Attachments: SOLR-6090.patch
>
>
> Many cloud tests have a DEBUG instance variable e.g.
> {code}
> private static final boolean DEBUG = false;
> {code}
> and
> {code}
> if (DEBUG) {
>       super.printLayout();
> }
> {code}
> I cannot find where this variable is set to true so the printLayout is never actually printed.
> We need to review and fix all such tests:
> # BasicDistributedZKTest.doTest
> # CollectionsAPIAsyncDistributedZkTest.doTest
> # CollectionsAPIDistributedZkTest
> # CustomCollectionTest
> # UnloadDistributedZkTest
> This is not an exhaustive list.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org