You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by za...@apache.org on 2014/05/22 06:23:58 UTC
[1/2] git commit: running original windows.open,
inAppBrowser is overriding it no need to place CSS in every page
anymore
Repository: cordova-plugin-dialogs
Updated Branches:
refs/heads/master 32c531b5c -> e4829eb07
running original windows.open, inAppBrowser is overriding it
no need to place CSS in every page anymore
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/6ab473d9
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/6ab473d9
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/6ab473d9
Branch: refs/heads/master
Commit: 6ab473d95aea26f8ca270956e8b4dcd955e86d0c
Parents: 1374373
Author: Piotr Zalewa <pi...@zalewa.info>
Authored: Tue Apr 29 14:51:33 2014 +0200
Committer: Piotr Zalewa <pi...@zalewa.info>
Committed: Tue Apr 29 14:51:33 2014 +0200
----------------------------------------------------------------------
src/firefoxos/notification.js | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/6ab473d9/src/firefoxos/notification.js
----------------------------------------------------------------------
diff --git a/src/firefoxos/notification.js b/src/firefoxos/notification.js
index 78516dc..a05a58b 100644
--- a/src/firefoxos/notification.js
+++ b/src/firefoxos/notification.js
@@ -19,24 +19,18 @@
*
*/
-var cssId = 'notification-plugin-css';
-if (!document.getElementById(cssId))
-{
- var head = document.getElementsByTagName('head')[0];
- var link = document.createElement('link');
- link.id = cssId;
- link.rel = 'stylesheet';
- link.type = 'text/css';
- link.href = '/css/notification.css';
- link.media = 'all';
- head.appendChild(link);
-}
+var modulemapper = require('cordova/modulemapper');
+
+
+var origOpenFunc = modulemapper.getOriginalSymbol(window, 'window.open');
+
function _empty() {}
+
function modal(message, callback, title, buttonLabels, domObjects) {
var mainWindow = window;
- var modalWindow = window.open();
+ var modalWindow = origOpenFunc();
var modalDocument = modalWindow.document;
modalDocument.write(
[2/2] git commit: Merge branch 'fix_inappbrowser_compatibility'
Posted by za...@apache.org.
Merge branch 'fix_inappbrowser_compatibility'
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/e4829eb0
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/e4829eb0
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/e4829eb0
Branch: refs/heads/master
Commit: e4829eb07fa5a4c8400ba271c5580ac425eb4640
Parents: 32c531b 6ab473d
Author: Piotr Zalewa <pi...@zalewa.info>
Authored: Thu May 22 06:23:15 2014 +0200
Committer: Piotr Zalewa <pi...@zalewa.info>
Committed: Thu May 22 06:23:15 2014 +0200
----------------------------------------------------------------------
src/firefoxos/notification.js | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
----------------------------------------------------------------------