You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/04 14:12:35 UTC
[GitHub] [spark] FelixYik opened a new pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
FelixYik opened a new pull request #31015:
URL: https://github.com/apache/spark/pull/31015
### What changes were proposed in this pull request?
<!--
For AllJobsPage class, AllJobsPage gets the schedulingMode of enumerated type by loading the spark.scheduler.mode configuration from Sparkconf, but an enumeration conversion error occurs when I set the value of this configuration to lowercase.
The reason for this problem is that the value of the SchedulingMode enumeration class is uppercase, which occurs when I configure spark. scheduler.mode to be lowercase.
I saw that the #org.apache.spark.scheduler.TaskSchedulerImpl class convert the spark. scheduler.mode value to uppercase, so I think it should be converted in AllJobsPage as well.
-->
### Why are the changes needed?
<!--
An enumerated conversion error occurred with Spark when I set the value of this configuration to lowercase.
-->
### How was this patch tested?
<!--
I tested this by creating AllJobsPageSuite.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756780928
**[Test build #133844 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133844/testReport)** for PR 31015 at commit [`e962965`](https://github.com/apache/spark/commit/e962965dfe067718acc8718dab392d6db196566e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-755303853
cc @gengliangwang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-757091165
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38449/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756466442
**[Test build #133814 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133814/testReport)** for PR 31015 at commit [`5baf969`](https://github.com/apache/spark/commit/5baf9697b55a28163e49f8a6d52c1887d1ee366b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756755924
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38428/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756519945
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133814/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756776885
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38428/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553348680
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -277,15 +277,17 @@ private[ui] class AllJobsPage(parent: JobsTab, store: AppStatusStore) extends We
s"${appSummary.numCompletedJobs}, only showing ${completedJobs.size}"
}
+ // SPARK-33991 Avoid enumeration conversion error.
val schedulingMode = store.environmentInfo().sparkProperties.toMap
.get(SCHEDULER_MODE.key)
- .map { mode => SchedulingMode.withName(mode).toString }
+ .map { mode => SchedulingMode.withName(mode.toUpperCase(Locale.ROOT)).toString }
.getOrElse("Unknown")
val summary: NodeSeq =
<div>
<ul class="list-unstyled">
<li>
+
Review comment:
But an enumerated conversion error occurred with Spark when I set the value of this spark.scheduler.mode to 'fair'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553711942
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
I mean we need to test whether the page is rendered and the scheduling mode is displayed with no error when we visit `http://localhost:4040/jobs/` even though we configure the scheduling mode like `spark.scheduler.mode=fair` instead of `spark.scheculer.mode=FAIR`.
Currently, we can get the following error when we visit `http://localhost:4040/jobs/` if we set the scheduling mode in lower case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756507740
@yikf The R test failure seems to be irrelevant to this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-755775563
also cc: @sarutak
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756845711
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38433/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-757634965
> The change looks OK to me.
Hi，Thank you for your response，Can you merge it into master branch for me? Thank you so much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553922361
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
What I intend is adding a test using Selenium like other tests in `UISeleniumSuite`., then you don't need to add `getScheduleMode`.
Here is an example.
https://github.com/apache/spark/blob/71d261ab8fb3e7fb22d2687b8e038129ca766a65/core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala#L723-L738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553706969
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
The latest change doesn't include test. Could you add one to `UISeleniumSuite`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553963657
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
Hi @sarutak , I don't understand that can i get <strong> element?
`find(linkText("Scheduling Mode")).get.text should be("FAIR")`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-753997804
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-755366498
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38335/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
yikf commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-755261396
@wangyum would you take a look of the PR, the update is very simple. Thanks very much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756782006
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133844/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756502001
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38403/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756519945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-757104325
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133860/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553709439
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
> The latest change doesn't include test. Could you add one to `UISeleniumSuite`?
oh, Because i found that there are tests for method `render` yesterday.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756144252
**[Test build #133799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133799/testReport)** for PR 31015 at commit [`12c5652`](https://github.com/apache/spark/commit/12c56528fee64cbdebe4722997218a5efdb34c85).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-755322328
**[Test build #133747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133747/testReport)** for PR 31015 at commit [`1131a8b`](https://github.com/apache/spark/commit/1131a8bf4d6fd9fd6d18c8bcea314ea7b876c19a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553972204
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
Hi @sarutak , I am so sorry，I haven't created PR before，I understand what you mean now。
I have removed `getSchedulingMode` and add a suit like other tests in `UISeleniumSuite`,Thanks very much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756509080
> @yikf The R test failure irrelevant to this change.
@sarutak Ok, please review... Thanks very much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756782088
**[Test build #133839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133839/testReport)** for PR 31015 at commit [`35e525a`](https://github.com/apache/spark/commit/35e525ac651749f4c44abe79421a9831cf2441cb).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756509819
**[Test build #133814 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133814/testReport)** for PR 31015 at commit [`5baf969`](https://github.com/apache/spark/commit/5baf9697b55a28163e49f8a6d52c1887d1ee366b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553709439
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
> The latest change doesn't include test. Could you add one to `UISeleniumSuite`?
oh, Because i found that there are tests for method `render` yestoday.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-753997804
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756822579
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38433/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756184996
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38388/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756251830
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133799/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553963657
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
Hi @sarutak , I don't understand that can i get <strong> element?
`val conf = Map("spark.scheduler.mode" -> "fair")
withSpark(newSparkContext(additionalConfs = conf)) { sc =>
val rdd = sc.parallelize(0 to 100, 100).repartition(10).cache()
rdd.count()
eventually(timeout(5.seconds), interval(50.milliseconds)) {
goToUi(sc, "/jobs")
find(linkText("Scheduling Mode")).get.text should contain("FAIR")
}
}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756782006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553348680
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -277,15 +277,17 @@ private[ui] class AllJobsPage(parent: JobsTab, store: AppStatusStore) extends We
s"${appSummary.numCompletedJobs}, only showing ${completedJobs.size}"
}
+ // SPARK-33991 Avoid enumeration conversion error.
val schedulingMode = store.environmentInfo().sparkProperties.toMap
.get(SCHEDULER_MODE.key)
- .map { mode => SchedulingMode.withName(mode).toString }
+ .map { mode => SchedulingMode.withName(mode.toUpperCase(Locale.ROOT)).toString }
.getOrElse("Unknown")
val summary: NodeSeq =
<div>
<ul class="list-unstyled">
<li>
+
Review comment:
But an enumerated conversion error occurred with Spark when I set the value of this spark.scheduler.mode to 'fair'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-757101890
**[Test build #133860 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133860/testReport)** for PR 31015 at commit [`e26fea9`](https://github.com/apache/spark/commit/e26fea92f75fff169cf5b32dd2220e6728ce6817).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-755425380
**[Test build #133747 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133747/testReport)** for PR 31015 at commit [`1131a8b`](https://github.com/apache/spark/commit/1131a8bf4d6fd9fd6d18c8bcea314ea7b876c19a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756213569
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38388/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756780928
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553914753
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
Hi @sarutak ，I've added the test in `UISeleniumSuite`, thx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756808694
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133839/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756519945
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133814/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756466442
**[Test build #133814 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133814/testReport)** for PR 31015 at commit [`5baf969`](https://github.com/apache/spark/commit/5baf9697b55a28163e49f8a6d52c1887d1ee366b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756806408
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38433/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756776885
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553914753
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
Hi @sarutak ，I've added the test in `UISeleniumSuite`, thx.
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
Hi @sarutak , I don't understand that can i get <strong> element?
`val conf = Map("spark.scheduler.mode" -> "fair")
withSpark(newSparkContext(additionalConfs = conf)) { sc =>
val rdd = sc.parallelize(0 to 100, 100).repartition(10).cache()
rdd.count()
eventually(timeout(5.seconds), interval(50.milliseconds)) {
goToUi(sc, "/jobs")
find(linkText("Scheduling Mode")).get.text should contain("FAIR")
}
}`
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
Hi @sarutak , I don't understand that can i get <strong> element?
`val conf = Map("spark.scheduler.mode" -> "fair")
withSpark(newSparkContext(additionalConfs = conf)) { sc =>
val rdd = sc.parallelize(0 to 100, 100).repartition(10).cache()
rdd.count()
eventually(timeout(5.seconds), interval(50.milliseconds)) {
goToUi(sc, "/jobs")
find(linkText("Scheduling Mode")).get.text should contain("FAIR")
}
}`
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
Hi @sarutak , I don't understand that can i get <strong> element?
`find(linkText("Scheduling Mode")).get.text should be("FAIR")`
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
Hi @sarutak , I am so sorry，I haven't created PR before，I understand what you mean now。
I have removed `getSchedulingMode` and add a suit like other tests in `UISeleniumSuite`,Thanks very much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553735626
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
In `UISeleniumSuite.scala`，due to import scalaTest，I may not be able to mock，and I see that `AllJobsPage.scala` doesn't has own suite，May i add a new suite？thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756480031
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38403/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553963657
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
Hi @sarutak , I don't understand that can i get <strong> element?
`val conf = Map("spark.scheduler.mode" -> "fair")
withSpark(newSparkContext(additionalConfs = conf)) { sc =>
val rdd = sc.parallelize(0 to 100, 100).repartition(10).cache()
rdd.count()
eventually(timeout(5.seconds), interval(50.milliseconds)) {
goToUi(sc, "/jobs")
find(linkText("Scheduling Mode")).get.text should contain("FAIR")
}
}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553341403
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
Hi @sarutak I found that there are tests for method `render`,So we can remove `getSchedulingMode`,please review, Thanks very much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553711942
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
I mean we need to test whether the page is rendered and the scheduling mode is displayed with no error when we visit `http://localhost:4040/jobs/` even though we configure the scheduling mode like `spark.scheduler.mode=fair` instead of `spark.scheculer.mode=FAIR`.
Currently, we get the following error when we visit `http://localhost:4040/jobs/` if we set the scheduling mode in lower case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756144252
**[Test build #133799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133799/testReport)** for PR 31015 at commit [`12c5652`](https://github.com/apache/spark/commit/12c56528fee64cbdebe4722997218a5efdb34c85).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-757098863
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38449/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-757098863
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38449/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756845711
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38433/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553922361
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
What I intend is adding a test using Selenium like other tests in `UISeleniumSuite`., then you don't need to add `getScheduleMode`.
Here is an example.
https://github.com/apache/spark/blob/71d261ab8fb3e7fb22d2687b8e038129ca766a65/core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala#L723-738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-755303492
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756780928
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553058804
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -279,13 +289,14 @@ private[ui] class AllJobsPage(parent: JobsTab, store: AppStatusStore) extends We
val schedulingMode = store.environmentInfo().sparkProperties.toMap
Review comment:
Hi @sarutak ,Thanks for reviewin，I see your thoughts, I will add the test to `UISeleniumSuite` and replace this duplicated code with the method call of `getSchedulingMode()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-755347969
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38335/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756509080
> @yikf The R test failure irrelevant to this change.
@sarutak Ok, please review... Thanks very much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-755391396
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38335/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756482951
@sarutak why fails SparkR unit tests， file:/tmp/RtmpIMrsYG/sparkr-test2375f14226616.parquet/_temporary does not exist？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756509080
> @yikf The R test failure irrelevant to this change.
@sarutak Ok, please review... Thanks very much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-757104325
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133860/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756728292
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756491166
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38403/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756502001
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38403/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-755432217
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133747/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756167024
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38388/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-757093783
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38449/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756251830
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133799/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756776885
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38428/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756743223
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38428/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
yikf commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-754005897
yes, please.
At 2021-01-04 22:14:02, "UCB AMPLab" <no...@github.com> wrote:
Can one of the admins verify this patch?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-755391396
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38335/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #31015:
URL: https://github.com/apache/spark/pull/31015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553028548
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
Is it sufficient to add a test to `UISeleniumSuite` rather than adding a new Suite?
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -279,13 +289,14 @@ private[ui] class AllJobsPage(parent: JobsTab, store: AppStatusStore) extends We
val schedulingMode = store.environmentInfo().sparkProperties.toMap
Review comment:
Could you replace this duplicated code with the method call of `getSchedulingMode()`, or if we can avoid adding the new Suite as I mentioned elsewhere, we can remove `getSchedulingMode`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756235881
**[Test build #133799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133799/testReport)** for PR 31015 at commit [`12c5652`](https://github.com/apache/spark/commit/12c56528fee64cbdebe4722997218a5efdb34c85).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-757087206
**[Test build #133860 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133860/testReport)** for PR 31015 at commit [`e26fea9`](https://github.com/apache/spark/commit/e26fea92f75fff169cf5b32dd2220e6728ce6817).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553922361
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
What I intend is adding a test using Selenium like other tests in `UISeleniumSuite`., then you don't need to add `getScheduleMode`.
Here is an example.
https://github.com/apache/spark/blob/71d261ab8fb3e7fb22d2687b8e038129ca766a65/core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala#L723-738
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
What I intend is adding a test using Selenium like other tests in `UISeleniumSuite`., then you don't need to add `getScheduleMode`.
Here is an example.
https://github.com/apache/spark/blob/71d261ab8fb3e7fb22d2687b8e038129ca766a65/core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala#L723-L738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] FelixYik commented on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
FelixYik commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-753999697
@cloud-fan @zsxwing @jiangxb1987 @jerryshao please review my separated PR. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
yikf commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553735626
##########
File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.jobs
+
+import javax.servlet.http.HttpServletRequest
+
+import org.mockito.Mockito._
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.status.AppStatusStore
+import org.apache.spark.status.api.v1
+
+class AllJobsPageSuite extends SparkFunSuite {
Review comment:
In `UISeleniumSuite.scala`，due to import scalaTest，I may not be able to mock，and I see that `AllJobsPage.scala` doesn't has own suite，May i add a new suite？thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-757087206
**[Test build #133860 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133860/testReport)** for PR 31015 at commit [`e26fea9`](https://github.com/apache/spark/commit/e26fea92f75fff169cf5b32dd2220e6728ce6817).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756213569
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38388/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yikf removed a comment on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
yikf removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-754005897
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] FelixYik commented on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
FelixYik commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-753999885
> Can one of the admins verify this patch?
yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756728292
**[Test build #133839 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133839/testReport)** for PR 31015 at commit [`35e525a`](https://github.com/apache/spark/commit/35e525ac651749f4c44abe79421a9831cf2441cb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-755322328
**[Test build #133747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133747/testReport)** for PR 31015 at commit [`1131a8b`](https://github.com/apache/spark/commit/1131a8bf4d6fd9fd6d18c8bcea314ea7b876c19a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553345489
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -277,15 +277,17 @@ private[ui] class AllJobsPage(parent: JobsTab, store: AppStatusStore) extends We
s"${appSummary.numCompletedJobs}, only showing ${completedJobs.size}"
}
+ // SPARK-33991 Avoid enumeration conversion error.
val schedulingMode = store.environmentInfo().sparkProperties.toMap
.get(SCHEDULER_MODE.key)
- .map { mode => SchedulingMode.withName(mode).toString }
+ .map { mode => SchedulingMode.withName(mode.toUpperCase(Locale.ROOT)).toString }
.getOrElse("Unknown")
val summary: NodeSeq =
<div>
<ul class="list-unstyled">
<li>
+
Review comment:
nit: unnecessary change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-757999788
Merged to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756781979
**[Test build #133844 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133844/testReport)** for PR 31015 at commit [`e962965`](https://github.com/apache/spark/commit/e962965dfe067718acc8718dab392d6db196566e).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31015: [SPARK-33991][CORE][WEBUI] Repair enumeration conversion error for AllJobsPage
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-756507740
@yikf The R test failure irrelevant to this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-755432217
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133747/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] FelixYik edited a comment on pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.
Posted by GitBox <gi...@apache.org>.
FelixYik edited a comment on pull request #31015:
URL: https://github.com/apache/spark/pull/31015#issuecomment-753999885
> Can one of the admins verify this patch?
yes,please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org