You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/01/11 03:11:35 UTC
[GitHub] [incubator-kyuubi] yaooqinn opened a new pull request #1717: Extract rat configurations from pom to file
yaooqinn opened a new pull request #1717:
URL: https://github.com/apache/incubator-kyuubi/pull/1717
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Extract rat configurations from pom to file
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [X] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1717: Extract rat configurations from pom to file
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1717:
URL: https://github.com/apache/incubator-kyuubi/pull/1717#discussion_r781728021
##########
File path: .rat-excludes
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+**/.*/**
+**/*.json
+**/*.prefs
+**/*.log
+**/*.md
+**/*.iml
+**/target/**
+**/out/**
+**/spark-warehouse/**
+**/metastore_db/**
+**/licenses/LICENSE*
+**/licenses-binary/LICENSE*
+**/dependency-reduced-pom.xml
+**/scalastyle-output.xml
+NOTICE*
+docs/**
+build/apache-maven-*/**
+build/scala-*/**
+**/**/operation_logs/**/**
+**/**/server_operation_logs/**/**
+**/**/engine_operation_logs/**/**
+**/*.output.schema
+**/apache-kyuubi-*-bin*/**
+**/benchmarks/**
Review comment:
nit: new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1717: Extract rat configurations from pom to file
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1717:
URL: https://github.com/apache/incubator-kyuubi/pull/1717#issuecomment-1009574704
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1717: Extract rat configurations from pom to file
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1717:
URL: https://github.com/apache/incubator-kyuubi/pull/1717#discussion_r781728021
##########
File path: .rat-excludes
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+**/.*/**
+**/*.json
+**/*.prefs
+**/*.log
+**/*.md
+**/*.iml
+**/target/**
+**/out/**
+**/spark-warehouse/**
+**/metastore_db/**
+**/licenses/LICENSE*
+**/licenses-binary/LICENSE*
+**/dependency-reduced-pom.xml
+**/scalastyle-output.xml
+NOTICE*
+docs/**
+build/apache-maven-*/**
+build/scala-*/**
+**/**/operation_logs/**/**
+**/**/server_operation_logs/**/**
+**/**/engine_operation_logs/**/**
+**/*.output.schema
+**/apache-kyuubi-*-bin*/**
+**/benchmarks/**
Review comment:
nit: EOL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #1717: Extract rat configurations from pom to file
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #1717:
URL: https://github.com/apache/incubator-kyuubi/pull/1717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org