You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/24 14:20:53 UTC
[GitHub] [dubbo-go] watermelo opened a new pull request #539: Fix: defer in loop will cause resource leak
watermelo opened a new pull request #539:
URL: https://github.com/apache/dubbo-go/pull/539
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] flycash commented on a change in pull request #539: Fix: defer in loop will cause resource leak
Posted by GitBox <gi...@apache.org>.
flycash commented on a change in pull request #539:
URL: https://github.com/apache/dubbo-go/pull/539#discussion_r429648029
##########
File path: config/service_config.go
##########
@@ -119,8 +119,8 @@ func getRandomPort(protocolConfigs []*ProtocolConfig) *list.List {
if err != nil {
panic(perrors.New(fmt.Sprintf("Get tcp port error,err is {%v}", err)))
}
- defer tcp.Close()
ports.PushBack(strings.Split(tcp.Addr().String(), ":")[1])
+ tcp.Close()
Review comment:
I am not very sure whether `tcp.Addr().String()` will return something like "127.0.0.1" which will cause `ports.PushBack(strings.Split(tcp.Addr().String(), ":")[1])` panic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #539: Fix: defer in loop will cause resource leak
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #539:
URL: https://github.com/apache/dubbo-go/pull/539#issuecomment-633239244
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=h1) Report
> Merging [#539](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3&el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #539 +/- ##
===========================================
- Coverage 66.55% 66.33% -0.23%
===========================================
Files 184 184
Lines 9729 9706 -23
===========================================
- Hits 6475 6438 -37
- Misses 2613 2625 +12
- Partials 641 643 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.09% <100.00%> (ø)` | |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `76.81% <0.00%> (-4.47%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (-1.87%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `65.83% <0.00%> (-1.86%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [cluster/loadbalance/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9jb25zaXN0ZW50X2hhc2guZ28=) | `90.32% <0.00%> (-0.86%)` | :arrow_down: |
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.00% <0.00%> (-0.41%)` | :arrow_down: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `80.78% <0.00%> (-0.33%)` | :arrow_down: |
| [registry/consul/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL2xpc3RlbmVyLmdv) | `81.25% <0.00%> (-0.24%)` | :arrow_down: |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `56.25% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=footer). Last update [84b38fe...ef87095](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] watermelo closed pull request #539: Fix: defer in loop will cause resource leak
Posted by GitBox <gi...@apache.org>.
watermelo closed pull request #539:
URL: https://github.com/apache/dubbo-go/pull/539
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #539: Fix: defer in loop will cause resource leak
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #539:
URL: https://github.com/apache/dubbo-go/pull/539#discussion_r429647811
##########
File path: config/service_config.go
##########
@@ -119,8 +119,8 @@ func getRandomPort(protocolConfigs []*ProtocolConfig) *list.List {
if err != nil {
panic(perrors.New(fmt.Sprintf("Get tcp port error,err is {%v}", err)))
}
- defer tcp.Close()
ports.PushBack(strings.Split(tcp.Addr().String(), ":")[1])
+ tcp.Close()
Review comment:
I thought may panic in line 122 ,so use defer in loop .
In this case , resoure usage will under control .
what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #539: Fix: defer in loop will cause resource leak
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #539:
URL: https://github.com/apache/dubbo-go/pull/539#issuecomment-633239244
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=h1) Report
> Merging [#539](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3&el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #539 +/- ##
===========================================
- Coverage 66.55% 66.33% -0.23%
===========================================
Files 184 184
Lines 9729 9706 -23
===========================================
- Hits 6475 6438 -37
- Misses 2613 2625 +12
- Partials 641 643 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.09% <100.00%> (ø)` | |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `76.81% <0.00%> (-4.47%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (-1.87%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `65.83% <0.00%> (-1.86%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [cluster/loadbalance/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9jb25zaXN0ZW50X2hhc2guZ28=) | `90.32% <0.00%> (-0.86%)` | :arrow_down: |
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.00% <0.00%> (-0.41%)` | :arrow_down: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `80.78% <0.00%> (-0.33%)` | :arrow_down: |
| [registry/consul/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL2xpc3RlbmVyLmdv) | `81.25% <0.00%> (-0.24%)` | :arrow_down: |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `56.25% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=footer). Last update [84b38fe...7977848](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #539: Fix: defer in loop will cause resource leak
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #539:
URL: https://github.com/apache/dubbo-go/pull/539#issuecomment-633239244
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=h1) Report
> Merging [#539](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3&el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #539 +/- ##
===========================================
- Coverage 66.55% 66.33% -0.23%
===========================================
Files 184 184
Lines 9729 9706 -23
===========================================
- Hits 6475 6438 -37
- Misses 2613 2625 +12
- Partials 641 643 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.09% <100.00%> (ø)` | |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `76.81% <0.00%> (-4.47%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (-1.87%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `65.83% <0.00%> (-1.86%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [cluster/loadbalance/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9jb25zaXN0ZW50X2hhc2guZ28=) | `90.32% <0.00%> (-0.86%)` | :arrow_down: |
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.00% <0.00%> (-0.41%)` | :arrow_down: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `80.78% <0.00%> (-0.33%)` | :arrow_down: |
| [registry/consul/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL2xpc3RlbmVyLmdv) | `81.25% <0.00%> (-0.24%)` | :arrow_down: |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `56.25% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=footer). Last update [84b38fe...159b48e](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] watermelo commented on a change in pull request #539: Fix: defer in loop will cause resource leak
Posted by GitBox <gi...@apache.org>.
watermelo commented on a change in pull request #539:
URL: https://github.com/apache/dubbo-go/pull/539#discussion_r429648582
##########
File path: config/service_config.go
##########
@@ -119,8 +119,8 @@ func getRandomPort(protocolConfigs []*ProtocolConfig) *list.List {
if err != nil {
panic(perrors.New(fmt.Sprintf("Get tcp port error,err is {%v}", err)))
}
- defer tcp.Close()
ports.PushBack(strings.Split(tcp.Addr().String(), ":")[1])
+ tcp.Close()
Review comment:
updated.
##########
File path: config/service_config.go
##########
@@ -119,8 +119,8 @@ func getRandomPort(protocolConfigs []*ProtocolConfig) *list.List {
if err != nil {
panic(perrors.New(fmt.Sprintf("Get tcp port error,err is {%v}", err)))
}
- defer tcp.Close()
ports.PushBack(strings.Split(tcp.Addr().String(), ":")[1])
+ tcp.Close()
Review comment:
updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #539: Fix: defer in loop will cause resource leak
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #539:
URL: https://github.com/apache/dubbo-go/pull/539#issuecomment-633239244
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=h1) Report
> Merging [#539](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #539 +/- ##
===========================================
- Coverage 66.55% 66.52% -0.03%
===========================================
Files 184 184
Lines 9729 9707 -22
===========================================
- Hits 6475 6458 -17
+ Misses 2613 2609 -4
+ Partials 641 640 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.31% <66.66%> (+0.22%)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (-2.81%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `65.83% <0.00%> (-1.86%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [cluster/loadbalance/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9jb25zaXN0ZW50X2hhc2guZ28=) | `90.32% <0.00%> (-0.86%)` | :arrow_down: |
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.00% <0.00%> (-0.41%)` | :arrow_down: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `80.78% <0.00%> (-0.33%)` | :arrow_down: |
| [registry/consul/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL2xpc3RlbmVyLmdv) | `81.25% <0.00%> (-0.24%)` | :arrow_down: |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `56.25% <0.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=footer). Last update [84b38fe...7977848](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org