[GitHub] [arrow-datafusion] mingmwang commented on pull request #5661: Top down `EnforceSorting`, Extended testbench for `EnforceSorting` rule to prepare for refactors, additional functionality such as pushdowns over unions

["mingmwang (via GitHub)" <gi...@apache.org>]

mingmwang commented on PR #5661:
URL: https://github.com/apache/arrow-datafusion/pull/5661#issuecomment-1493277174

   @mustafasrepo @ozankabak 
   My original plan was try to leverage the top-down process to achieve two goals:
   1) Simply the optimization process, make it easily to understand
   2) Can do all the sort optimizations in one pass, 
   But when I start the implementation and testing I realize that it is quite hard to achieve the two goals at same time.  I think the new implementation is the hybrid of bottom-up and top-down approach but it is more complex. 
   I accept that in the current phase, we combine the two approaches to offer full functionality. But in future I think we should still pursue the goal to offer the full functionality in a pure top-down approach.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org