[jira] [Commented] (MRELEASE-979) Support NamingPolicies to manage Branch and Tag names

["Henning Schmiedehausen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MRELEASE-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893386#comment-15893386 ] 

Henning Schmiedehausen commented on MRELEASE-979:
-------------------------------------------------

Finally got around to review those changes and update our internal policy code to try to use this change.

The bad news: It is all broken for me. In fact, the code does not work at all.

- there are at least two places where the naming policy value is not copied over. The name always reverts to "default" by the time it hits the InputVariablesPhase.
- the naming policy is only called when scmTagName is not set, even for a branch name. This is counter-intuitive because I would not expect scmTagName to influence the release:branch operation.

and finally, the naming policy do not work with release:branch at all in non-interactive mode (which makes it pretty worthless to me):

- the policy is only executed when no scmTagName is set into defaultTag but then this value is never used again when in branchOperation mode. The execution always hits the "no branch name" given exception.

I will send a patch that addresses these problems. 

> Support NamingPolicies to manage Branch and Tag names
> -----------------------------------------------------
>
>                 Key: MRELEASE-979
>                 URL: https://issues.apache.org/jira/browse/MRELEASE-979
>             Project: Maven Release Plugin
>          Issue Type: Improvement
>          Components: branch, prepare, update-versions
>    Affects Versions: 2.5.3
>            Reporter: Henning Schmiedehausen
>             Fix For: 3.0.0
>
>
> The newly introduced VersionPolicy facility allows managing the development and release versions of projects when releasing, branching and updating versions.
> Most organizations will also have a policy around how branches and tags are named (which often have to match specific versioning patterns). The current VersionPolicy implementations do not allow this but it should be possible.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)