Re: [PR] Fix incorrect generated key handling for explicit auto-increment values [shardingsphere]

["somiljain2006 (via GitHub)" <gi...@apache.org>]

somiljain2006 commented on PR #38810:
URL: https://github.com/apache/shardingsphere/pull/38810#issuecomment-4853775876

   @terrymanu Thanks for the detailed review.
   
   I've updated the implementation to align with the existing connector metadata option design:
   
   * Changed `DialectGeneratedKeyOption` from a concrete class to an interface.
   * Added `DefaultGeneratedKeyOption` as the default implementation for the existing column-name/non-trigger behavior.
   * Updated `MySQLGeneratedKeyOption` to implement `DialectGeneratedKeyOption` directly instead of extending a concrete base class.
   * The MySQL/MariaDB metadata path continues to return `MySQLGeneratedKeyOption`, while the default implementation is available for dialects that only require the previous behavior.
   
   Let me know if there are any additional changes you'd like me to make.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org