You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/10 20:37:54 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #1684: simplify offsets checking

viirya commented on code in PR #1684:
URL: https://github.com/apache/arrow-rs/pull/1684#discussion_r869659746


##########
arrow/src/array/data.rs:
##########
@@ -726,19 +726,21 @@ impl ArrayData {
     /// Returns a reference to the data in `buffer` as a typed slice
     /// (typically `&[i32]` or `&[i64]`) after validating. The
     /// returned slice is guaranteed to have at least `self.len + 1`
-    /// entries
+    /// entries.
+    ///
+    /// For an empty array, the `buffer` can also be empty`.

Review Comment:
   A typo.
   
   ```suggestion
       /// For an empty array, the `buffer` can also be empty.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org