You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2012/08/08 02:41:20 UTC

Review Request: Cleanup the cgroups hierarchy when slave starts.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6456/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Description
-------

See summary.


Diffs
-----

  src/slave/cgroups_isolation_module.hpp de8f581 
  src/slave/cgroups_isolation_module.cpp 33e1ba7 

Diff: https://reviews.apache.org/r/6456/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request: Cleanup the cgroups hierarchy when slave starts.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6456/
-----------------------------------------------------------

(Updated Aug. 8, 2012, 12:59 a.m.)


Review request for mesos and Benjamin Hindman.


Changes
-------

Ben's comments.


Description
-------

See summary.


Diffs (updated)
-----

  src/slave/cgroups_isolation_module.hpp de8f581 
  src/slave/cgroups_isolation_module.cpp 33e1ba7 

Diff: https://reviews.apache.org/r/6456/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request: Cleanup the cgroups hierarchy when slave starts.

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6456/#review10002
-----------------------------------------------------------

Ship it!



src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/6456/#comment21204>

    Let's actually do strings::startsWith("mesos_cgroup_framework_") and then strings::contains("_executor_") and strings::contains("_tag"_).


- Benjamin Hindman


On Aug. 8, 2012, 12:41 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6456/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 12:41 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolation_module.hpp de8f581 
>   src/slave/cgroups_isolation_module.cpp 33e1ba7 
> 
> Diff: https://reviews.apache.org/r/6456/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>