You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/02/22 21:19:58 UTC
Review Request 43846: Added support for specifying detector to the
callback interface.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43846/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
This change adds support for passing in a master detector object to the callback interface. This can be used for testing master failover scenarios similar to how the driver already does it.
Diffs
-----
include/mesos/v1/scheduler.hpp 5e462c13ec2715888247eb7b4dc7a2b1d53e6bb1
src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75
src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0
Diff: https://reviews.apache.org/r/43846/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 43846: Added support for specifying detector to the
callback interface.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43846/#review121156
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 27, 2016, 4:48 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43846/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 4:48 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4686
> https://issues.apache.org/jira/browse/MESOS-4686
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds support for passing in a master detector object to the callback interface. This can be used for testing master failover scenarios similar to how the driver already does it.
>
>
> Diffs
> -----
>
> include/mesos/v1/scheduler.hpp 5e462c13ec2715888247eb7b4dc7a2b1d53e6bb1
> src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75
> src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0
>
> Diff: https://reviews.apache.org/r/43846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43846: Added support for specifying detector to the
callback interface.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43846/
-----------------------------------------------------------
(Updated Feb. 27, 2016, 4:48 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comments
Bugs: MESOS-4686
https://issues.apache.org/jira/browse/MESOS-4686
Repository: mesos
Description
-------
This change adds support for passing in a master detector object to the callback interface. This can be used for testing master failover scenarios similar to how the driver already does it.
Diffs (updated)
-----
include/mesos/v1/scheduler.hpp 5e462c13ec2715888247eb7b4dc7a2b1d53e6bb1
src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75
src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0
Diff: https://reviews.apache.org/r/43846/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 43846: Added support for specifying detector to the
callback interface.
Posted by Anand Mazumdar <ma...@gmail.com>.
> On Feb. 27, 2016, 2:43 a.m., Vinod Kone wrote:
> > src/scheduler/scheduler.cpp, lines 637-638
> > <https://reviews.apache.org/r/43846/diff/1/?file=1264752#file1264752line637>
> >
> > Yikes. Why are you doing it like this, instead of passing detector as an optional argument to the MesosProcess?
Agreed, my bad. I had tried to follow the existing pattern used in `TestMesosSchedulerDriver` but should have avoided it.
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43846/#review121054
-----------------------------------------------------------
On Feb. 22, 2016, 8:24 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43846/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 8:24 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4686
> https://issues.apache.org/jira/browse/MESOS-4686
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds support for passing in a master detector object to the callback interface. This can be used for testing master failover scenarios similar to how the driver already does it.
>
>
> Diffs
> -----
>
> include/mesos/v1/scheduler.hpp 5e462c13ec2715888247eb7b4dc7a2b1d53e6bb1
> src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75
> src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0
>
> Diff: https://reviews.apache.org/r/43846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43846: Added support for specifying detector to the
callback interface.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43846/#review121054
-----------------------------------------------------------
include/mesos/v1/scheduler.hpp (line 77)
<https://reviews.apache.org/r/43846/#comment182648>
I guess you made this protected because it is only used by TestMesos in tests? Please add a comment saying as much for posterity.
src/scheduler/scheduler.cpp (line 562)
<https://reviews.apache.org/r/43846/#comment182646>
don't do this. see below.
src/scheduler/scheduler.cpp (lines 637 - 638)
<https://reviews.apache.org/r/43846/#comment182645>
Yikes. Why are you doing it like this, instead of passing detector as an optional argument to the MesosProcess?
src/tests/mesos.hpp (lines 968 - 972)
<https://reviews.apache.org/r/43846/#comment182647>
why a new constructor instead of updating the above constructor. you can make detector Option<shared_ptr<>> with default None.
- Vinod Kone
On Feb. 22, 2016, 8:24 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43846/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 8:24 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4686
> https://issues.apache.org/jira/browse/MESOS-4686
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds support for passing in a master detector object to the callback interface. This can be used for testing master failover scenarios similar to how the driver already does it.
>
>
> Diffs
> -----
>
> include/mesos/v1/scheduler.hpp 5e462c13ec2715888247eb7b4dc7a2b1d53e6bb1
> src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75
> src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0
>
> Diff: https://reviews.apache.org/r/43846/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43846: Added support for specifying detector to the
callback interface.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43846/
-----------------------------------------------------------
(Updated Feb. 22, 2016, 8:24 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Added JIRA issue.
Bugs: MESOS-4686
https://issues.apache.org/jira/browse/MESOS-4686
Repository: mesos
Description
-------
This change adds support for passing in a master detector object to the callback interface. This can be used for testing master failover scenarios similar to how the driver already does it.
Diffs
-----
include/mesos/v1/scheduler.hpp 5e462c13ec2715888247eb7b4dc7a2b1d53e6bb1
src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75
src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0
Diff: https://reviews.apache.org/r/43846/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar