You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2020/08/19 15:10:22 UTC

[GitHub] [unomi] Taybou commented on a change in pull request #179: Improve scripting security

Taybou commented on a change in pull request #179:
URL: https://github.com/apache/unomi/pull/179#discussion_r473103981



##########
File path: scripting/src/main/java/org/apache/unomi/scripting/MvelScriptExecutor.java
##########
@@ -24,11 +24,20 @@
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
 
+/**
+ * MVEL script executor implementation
+ */
 public class MvelScriptExecutor implements ScriptExecutor {
 
+    private final static String INVALID_SCRIPT_MARKER = "Invalid String Marker";

Review comment:
       is it correct the placeholder text, or typo (script // string)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org