You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2012/11/02 23:26:36 UTC
svn commit: r1405191 -
/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java
Author: ggregory
Date: Fri Nov 2 22:26:36 2012
New Revision: 1405191
URL: http://svn.apache.org/viewvc?rev=1405191&view=rev
Log:
Unnecessary cast from BundleWiring to BundleWiring.
Modified:
logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java
Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java?rev=1405191&r1=1405190&r2=1405191&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java (original)
+++ logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java Fri Nov 2 22:26:36 2012
@@ -276,7 +276,7 @@ public class ResolverUtil<T> {
}
private void loadImplementationsInBundle(Test test, String packageName) {
- BundleWiring wiring = (BundleWiring)FrameworkUtil.getBundle(ResolverUtil.class).adapt(BundleWiring.class);
+ BundleWiring wiring = FrameworkUtil.getBundle(ResolverUtil.class).adapt(BundleWiring.class);
Collection<String> list = wiring.listResources(packageName, "*.class", BundleWiring.LISTRESOURCES_RECURSE);
for (String name : list) {
addIfMatching(test, name);
Re: svn commit: r1405191 - /logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java
Posted by Ralph Goers <rg...@apache.org>.
It may not, but I have had to fix problems several times from propel complaining when it doesn't so now I make sure it does. FWIW, maven is still targeting Java 5 but the compiler is a bit different.
Ralph
On Nov 2, 2012, at 8:17 PM, Gary Gregory <ga...@gmail.com> wrote:
> So we care about compiling on Java 7 but we have to stick to 5 as the
> requirement? I'm not sure that makes sense.
>
> Gary
>
> On Nov 2, 2012, at 23:14, Ralph Goers <ra...@dslextreme.com> wrote:
>
>> I reverted this change as it causes a compile error on Mac OS/X with Java 7.
>>
>> Ralph
>>
>> On Nov 2, 2012, at 3:26 PM, ggregory@apache.org wrote:
>>
>>> Author: ggregory
>>> Date: Fri Nov 2 22:26:36 2012
>>> New Revision: 1405191
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1405191&view=rev
>>> Log:
>>> Unnecessary cast from BundleWiring to BundleWiring.
>>>
>>> Modified:
>>> logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java
>>>
>>> Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java
>>> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java?rev=1405191&r1=1405190&r2=1405191&view=diff
>>> ==============================================================================
>>> --- logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java (original)
>>> +++ logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java Fri Nov 2 22:26:36 2012
>>> @@ -276,7 +276,7 @@ public class ResolverUtil<T> {
>>> }
>>>
>>> private void loadImplementationsInBundle(Test test, String packageName) {
>>> - BundleWiring wiring = (BundleWiring)FrameworkUtil.getBundle(ResolverUtil.class).adapt(BundleWiring.class);
>>> + BundleWiring wiring = FrameworkUtil.getBundle(ResolverUtil.class).adapt(BundleWiring.class);
>>> Collection<String> list = wiring.listResources(packageName, "*.class", BundleWiring.LISTRESOURCES_RECURSE);
>>> for (String name : list) {
>>> addIfMatching(test, name);
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r1405191 - /logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java
Posted by Gary Gregory <ga...@gmail.com>.
So we care about compiling on Java 7 but we have to stick to 5 as the
requirement? I'm not sure that makes sense.
Gary
On Nov 2, 2012, at 23:14, Ralph Goers <ra...@dslextreme.com> wrote:
> I reverted this change as it causes a compile error on Mac OS/X with Java 7.
>
> Ralph
>
> On Nov 2, 2012, at 3:26 PM, ggregory@apache.org wrote:
>
>> Author: ggregory
>> Date: Fri Nov 2 22:26:36 2012
>> New Revision: 1405191
>>
>> URL: http://svn.apache.org/viewvc?rev=1405191&view=rev
>> Log:
>> Unnecessary cast from BundleWiring to BundleWiring.
>>
>> Modified:
>> logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java
>>
>> Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java
>> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java?rev=1405191&r1=1405190&r2=1405191&view=diff
>> ==============================================================================
>> --- logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java (original)
>> +++ logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java Fri Nov 2 22:26:36 2012
>> @@ -276,7 +276,7 @@ public class ResolverUtil<T> {
>> }
>>
>> private void loadImplementationsInBundle(Test test, String packageName) {
>> - BundleWiring wiring = (BundleWiring)FrameworkUtil.getBundle(ResolverUtil.class).adapt(BundleWiring.class);
>> + BundleWiring wiring = FrameworkUtil.getBundle(ResolverUtil.class).adapt(BundleWiring.class);
>> Collection<String> list = wiring.listResources(packageName, "*.class", BundleWiring.LISTRESOURCES_RECURSE);
>> for (String name : list) {
>> addIfMatching(test, name);
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r1405191 - /logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java
Posted by Ralph Goers <ra...@dslextreme.com>.
I reverted this change as it causes a compile error on Mac OS/X with Java 7.
Ralph
On Nov 2, 2012, at 3:26 PM, ggregory@apache.org wrote:
> Author: ggregory
> Date: Fri Nov 2 22:26:36 2012
> New Revision: 1405191
>
> URL: http://svn.apache.org/viewvc?rev=1405191&view=rev
> Log:
> Unnecessary cast from BundleWiring to BundleWiring.
>
> Modified:
> logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java
>
> Modified: logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java?rev=1405191&r1=1405190&r2=1405191&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java (original)
> +++ logging/log4j/log4j2/trunk/core/src/main/java/org/apache/logging/log4j/core/config/plugins/ResolverUtil.java Fri Nov 2 22:26:36 2012
> @@ -276,7 +276,7 @@ public class ResolverUtil<T> {
> }
>
> private void loadImplementationsInBundle(Test test, String packageName) {
> - BundleWiring wiring = (BundleWiring)FrameworkUtil.getBundle(ResolverUtil.class).adapt(BundleWiring.class);
> + BundleWiring wiring = FrameworkUtil.getBundle(ResolverUtil.class).adapt(BundleWiring.class);
> Collection<String> list = wiring.listResources(packageName, "*.class", BundleWiring.LISTRESOURCES_RECURSE);
> for (String name : list) {
> addIfMatching(test, name);
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org