You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Philippe Mouawad <ph...@gmail.com> on 2013/02/25 07:39:08 UTC

Re: [Bug 54589] View Results Tree have a lot of Garbage characters Garbage characters

Hello sebb,
Regarding this do you agree with the fix I made eve if it is not as
complete as the one you propose.

Regards
Philippe

On Monday, February 25, 2013, wrote:

> https://issues.apache.org/bugzilla/show_bug.cgi?id=54589
>
> Sebb <sebb@apache.org <javascript:;>> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>              Status|RESOLVED                    |REOPENED
>          Resolution|FIXED                       |---
>
> --- Comment #3 from Sebb <sebb@apache.org <javascript:;>> ---
> (In reply to comment #2)
> >
> > Issues comes from the fact that response does not contain charset
> indication.
>
> The HTTP response headers don't contain the info, but the HTML does.
>
> However JMeter does not currently detect that; perhaps it should if there
> is no
> charset in the header.
>
> > So you need to add this (you must use nightly build that will be
> available
> > in some time):
> > sampleresult.default.encoding=GBK
>
> That assumes all the pages in the test have the same default.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
>


-- 
Cordialement.
Philippe Mouawad.

Re: [Bug 54589] View Results Tree have a lot of Garbage characters Garbage characters

Posted by sebb <se...@gmail.com>.
On 25 February 2013 11:03, sebb <se...@gmail.com> wrote:
> On 25 February 2013 06:39, Philippe Mouawad <ph...@gmail.com> wrote:
>> Hello sebb,
>> Regarding this do you agree with the fix I made eve if it is not as
>> complete as the one you propose.
>
> It's not ideal, but as it is optional it does not have to be used.
>
> So I would leave it for now; but need to review again before the next release.

I've fixed the code that extracted the meta-tag - that was the problem
all along - and that has had the effect of reverting the change made
to HttpSampleResult.

I suppose one could revert the visibilty change to the constant in
SampleResult, but it seems unnecessary to do so.

>> Regards
>> Philippe
>>
>> On Monday, February 25, 2013, wrote:
>>
>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=54589
>>>
>>> Sebb <sebb@apache.org <javascript:;>> changed:
>>>
>>>            What    |Removed                     |Added
>>>
>>> ----------------------------------------------------------------------------
>>>              Status|RESOLVED                    |REOPENED
>>>          Resolution|FIXED                       |---
>>>
>>> --- Comment #3 from Sebb <sebb@apache.org <javascript:;>> ---
>>> (In reply to comment #2)
>>> >
>>> > Issues comes from the fact that response does not contain charset
>>> indication.
>>>
>>> The HTTP response headers don't contain the info, but the HTML does.
>>>
>>> However JMeter does not currently detect that; perhaps it should if there
>>> is no
>>> charset in the header.
>>>
>>> > So you need to add this (you must use nightly build that will be
>>> available
>>> > in some time):
>>> > sampleresult.default.encoding=GBK
>>>
>>> That assumes all the pages in the test have the same default.
>>>
>>> --
>>> You are receiving this mail because:
>>> You are the assignee for the bug.
>>>
>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.

Re: [Bug 54589] View Results Tree have a lot of Garbage characters Garbage characters

Posted by sebb <se...@gmail.com>.
On 25 February 2013 06:39, Philippe Mouawad <ph...@gmail.com> wrote:
> Hello sebb,
> Regarding this do you agree with the fix I made eve if it is not as
> complete as the one you propose.

It's not ideal, but as it is optional it does not have to be used.

So I would leave it for now; but need to review again before the next release.

> Regards
> Philippe
>
> On Monday, February 25, 2013, wrote:
>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=54589
>>
>> Sebb <sebb@apache.org <javascript:;>> changed:
>>
>>            What    |Removed                     |Added
>>
>> ----------------------------------------------------------------------------
>>              Status|RESOLVED                    |REOPENED
>>          Resolution|FIXED                       |---
>>
>> --- Comment #3 from Sebb <sebb@apache.org <javascript:;>> ---
>> (In reply to comment #2)
>> >
>> > Issues comes from the fact that response does not contain charset
>> indication.
>>
>> The HTTP response headers don't contain the info, but the HTML does.
>>
>> However JMeter does not currently detect that; perhaps it should if there
>> is no
>> charset in the header.
>>
>> > So you need to add this (you must use nightly build that will be
>> available
>> > in some time):
>> > sampleresult.default.encoding=GBK
>>
>> That assumes all the pages in the test have the same default.
>>
>> --
>> You are receiving this mail because:
>> You are the assignee for the bug.
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.