[jira] [Commented] (CB-7231) Provide more control over CordovaProjectName vs CordovaAppName

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-7231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14122687#comment-14122687 ] 

ASF GitHub Bot commented on CB-7231:
------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-android/pull/118

    CB-7231 Adds support for --projectname option

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vladimir-kotikov/cordova-android CB-7231

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #118
    
----
commit 0d2b2890c03b187a16c1b390c57b1f2c3b098a88
Author: Vladimir Kotikov <v-...@microsoft.com>
Date:   2014-09-04T09:46:50Z

    Adds support for --projectname option

----


> Provide more control over CordovaProjectName vs CordovaAppName
> --------------------------------------------------------------
>
>                 Key: CB-7231
>                 URL: https://issues.apache.org/jira/browse/CB-7231
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaLib
>    Affects Versions: Master
>            Reporter: Carlos Santana
>
> Discussion in mailing  list
> http://callback.markmail.org/thread/lsk6vewllowofxf3
> and here:
> http://callback.markmail.org/thread/qk7eztl46rmvklch
> When user wants to have the App name show on the screen of the they might characters that are incompatible with file and directory names.
> Today when a user sets a custom name via cli create, it's use for app name but also for native files and directory names (depends on platform) 
>  cordova create 'שלום'
> the value 'שלום' will be use for the cordova project path, app name, and native files.
> Or another use case is config.xml, if user sets a new name  like
> <name>שלום</name>
> then runs a cordova build
> then the app name and native files will refactor with new name.
> The enhancement is to allow the developer to specify an app name without affecting the native platform files.
> One proposal for config.xml is to keep backward compatibility is to use attribute in 'project' in name tag like
> if attribute not specify (i.e. default) or not different from previous build then do not change native plafform files or directory names.
> Use will be able to control both values like:
> <name project="HelloCordova">שלום</name>
> For the cli or platform shell script then allow to pass optional parameter for projectname, if not pass then appname is use to keep backwards compatibility
> CLI:
> cordova create MyCordovaFolder com.example.mycordova שלום --project="HelloCordova"
> or Shell script 
> like in cordova-ios/bin/create
> Usage: $0 [--shared] [--arc] [--cli] <path_to_new_project> <package_name> <project_name> [<project_template_dir>]
> project_name only affects app name, and not project files, default value HelloCordova will be use unless specify like --project
> cordova-ios/bin/create projectpath com.example.myapp שלום --project="myxcodeprojectname"
> Cordova CLI (metadata platform parsers) and all platforms create scripts will need to be updated



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)