You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2016/09/29 02:01:56 UTC
[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp
Jean-Daniel Cryans has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4560
Change subject: [docs] Release note for OperationResponse.getWriteTimestamp
......................................................................
[docs] Release note for OperationResponse.getWriteTimestamp
See https://gerrit.cloudera.org/#/c/4487/
Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
---
M docs/release_notes.adoc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/4560/1
--
To view, visit http://gerrit.cloudera.org:8080/4560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [docs] Release note for OperationResponse.getWriteTimestamp
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4560/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 49: renamed
Nit: renamed to
PS1, Line 50: emphasis
Nit: emphasize that it doesn't return milliseconds.
--
To view, visit http://gerrit.cloudera.org:8080/4560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [docs] Release note for OperationResponse.getWriteTimestamp
......................................................................
Patch Set 5:
Had to rebase due to your changes, Adar.
--
To view, visit http://gerrit.cloudera.org:8080/4560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4560
to look at the new patch set (#3).
Change subject: [docs] Release note for OperationResponse.getWriteTimestamp
......................................................................
[docs] Release note for OperationResponse.getWriteTimestamp
See https://gerrit.cloudera.org/#/c/4487/
Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
---
M docs/release_notes.adoc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/4560/3
--
To view, visit http://gerrit.cloudera.org:8080/4560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [docs] Release note for OperationResponse.getWriteTimestamp
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: [docs] Release note for OperationResponse.getWriteTimestamp
......................................................................
[docs] Release note for OperationResponse.getWriteTimestamp
See https://gerrit.cloudera.org/#/c/4487/
Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
Reviewed-on: http://gerrit.cloudera.org:8080/4560
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Jean-Daniel Cryans <jd...@apache.org>
---
M docs/release_notes.adoc
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Jean-Daniel Cryans: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [docs] Release note for OperationResponse.getWriteTimestamp
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4560/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 50: emphasis
> You missed "emphasize" for "emphasis".
oops
--
To view, visit http://gerrit.cloudera.org:8080/4560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4560
to look at the new patch set (#4).
Change subject: [docs] Release note for OperationResponse.getWriteTimestamp
......................................................................
[docs] Release note for OperationResponse.getWriteTimestamp
See https://gerrit.cloudera.org/#/c/4487/
Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
---
M docs/release_notes.adoc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/4560/4
--
To view, visit http://gerrit.cloudera.org:8080/4560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4560
to look at the new patch set (#5).
Change subject: [docs] Release note for OperationResponse.getWriteTimestamp
......................................................................
[docs] Release note for OperationResponse.getWriteTimestamp
See https://gerrit.cloudera.org/#/c/4487/
Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
---
M docs/release_notes.adoc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/4560/5
--
To view, visit http://gerrit.cloudera.org:8080/4560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has uploaded a new patch set (#2).
Change subject: [docs] Release note for OperationResponse.getWriteTimestamp
......................................................................
[docs] Release note for OperationResponse.getWriteTimestamp
See https://gerrit.cloudera.org/#/c/4487/
Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
---
M docs/release_notes.adoc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/4560/2
--
To view, visit http://gerrit.cloudera.org:8080/4560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [docs] Release note for OperationResponse.getWriteTimestamp
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4560/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 49: renamed
> Nit: renamed to
Done
PS1, Line 50: emphasis
> Nit: emphasize that it doesn't return milliseconds.
Done
--
To view, visit http://gerrit.cloudera.org:8080/4560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [docs] Release note for OperationResponse.getWriteTimestamp
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [docs] Release note for OperationResponse.getWriteTimestamp
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [docs] Release note for OperationResponse.getWriteTimestamp
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4560/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 50: emphasis
> Done
You missed "emphasize" for "emphasis".
--
To view, visit http://gerrit.cloudera.org:8080/4560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f81b1c70bc8f8be7f5529762ac9a9622dec00f0
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes