You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/12/11 20:19:27 UTC

Review Request 41264: Stop-and-Start Upgrade: Fix unit tests that were ignored/missing on agent

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41264/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.


Bugs: AMBARI-14347
    https://issues.apache.org/jira/browse/AMBARI-14347


Repository: ambari


Description
-------

Fix some unittests, remove stale code, add few missing unit tests


Diffs
-----

  ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py 30bf2df 
  ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py a4025eb 
  ambari-agent/src/test/python/ambari_agent/TestMain.py d044027 
  ambari-agent/src/test/python/ambari_agent/TestMetricAlert.py 30ba438 
  ambari-agent/src/test/python/ambari_agent/TestRecoveryManager.py a2b4968 
  ambari-agent/src/test/python/ambari_agent/TestRegistration.py bac4945 
  ambari-agent/src/test/python/ambari_agent/TestScriptAlert.py 7201a10 
  ambari-agent/src/test/python/resource_management/TestDatanodeHelper.py 2d9996c 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 7000861 
  ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 3414c22 
  ambari-server/src/test/python/TestAmbariServer.py 16b46b1 
  ambari-server/src/test/python/TestSetupAgent.py 5f66e2a 
  ambari-server/src/test/python/custom_actions/TestRemoveBits.py PRE-CREATION 
  ambari-server/src/test/python/custom_actions/test_ru_set_all.py 162a2fd 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py b011f93 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 18e25c0 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus_prod.py 74877af 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py 8017ec2 

Diff: https://reviews.apache.org/r/41264/diff/


Testing
-------

mvn clean test


Thanks,

Dmitro Lisnichenko


Re: Review Request 41264: Stop-and-Start Upgrade: Fix unit tests that were ignored/missing on agent

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41264/#review110019
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Dec. 11, 2015, 2:19 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41264/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 2:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-14347
>     https://issues.apache.org/jira/browse/AMBARI-14347
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fix some unittests, remove stale code, add few missing unit tests
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py 30bf2df 
>   ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py a4025eb 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py d044027 
>   ambari-agent/src/test/python/ambari_agent/TestMetricAlert.py 30ba438 
>   ambari-agent/src/test/python/ambari_agent/TestRecoveryManager.py a2b4968 
>   ambari-agent/src/test/python/ambari_agent/TestRegistration.py bac4945 
>   ambari-agent/src/test/python/ambari_agent/TestScriptAlert.py 7201a10 
>   ambari-agent/src/test/python/resource_management/TestDatanodeHelper.py 2d9996c 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 7000861 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 3414c22 
>   ambari-server/src/test/python/TestAmbariServer.py 16b46b1 
>   ambari-server/src/test/python/TestSetupAgent.py 5f66e2a 
>   ambari-server/src/test/python/custom_actions/TestRemoveBits.py PRE-CREATION 
>   ambari-server/src/test/python/custom_actions/test_ru_set_all.py 162a2fd 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py b011f93 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 18e25c0 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus_prod.py 74877af 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py 8017ec2 
> 
> Diff: https://reviews.apache.org/r/41264/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 41264: Stop-and-Start Upgrade: Fix unit tests that were ignored/missing on agent

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41264/#review110005
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Dec. 11, 2015, 7:19 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41264/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 7:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-14347
>     https://issues.apache.org/jira/browse/AMBARI-14347
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fix some unittests, remove stale code, add few missing unit tests
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py 30bf2df 
>   ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py a4025eb 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py d044027 
>   ambari-agent/src/test/python/ambari_agent/TestMetricAlert.py 30ba438 
>   ambari-agent/src/test/python/ambari_agent/TestRecoveryManager.py a2b4968 
>   ambari-agent/src/test/python/ambari_agent/TestRegistration.py bac4945 
>   ambari-agent/src/test/python/ambari_agent/TestScriptAlert.py 7201a10 
>   ambari-agent/src/test/python/resource_management/TestDatanodeHelper.py 2d9996c 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 7000861 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 3414c22 
>   ambari-server/src/test/python/TestAmbariServer.py 16b46b1 
>   ambari-server/src/test/python/TestSetupAgent.py 5f66e2a 
>   ambari-server/src/test/python/custom_actions/TestRemoveBits.py PRE-CREATION 
>   ambari-server/src/test/python/custom_actions/test_ru_set_all.py 162a2fd 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py b011f93 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 18e25c0 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus_prod.py 74877af 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py 8017ec2 
> 
> Diff: https://reviews.apache.org/r/41264/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 41264: Stop-and-Start Upgrade: Fix unit tests that were ignored/missing on agent

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41264/#review110029
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Dec. 11, 2015, 2:19 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41264/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 2:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-14347
>     https://issues.apache.org/jira/browse/AMBARI-14347
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fix some unittests, remove stale code, add few missing unit tests
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py 30bf2df 
>   ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py a4025eb 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py d044027 
>   ambari-agent/src/test/python/ambari_agent/TestMetricAlert.py 30ba438 
>   ambari-agent/src/test/python/ambari_agent/TestRecoveryManager.py a2b4968 
>   ambari-agent/src/test/python/ambari_agent/TestRegistration.py bac4945 
>   ambari-agent/src/test/python/ambari_agent/TestScriptAlert.py 7201a10 
>   ambari-agent/src/test/python/resource_management/TestDatanodeHelper.py 2d9996c 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 7000861 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 3414c22 
>   ambari-server/src/test/python/TestAmbariServer.py 16b46b1 
>   ambari-server/src/test/python/TestSetupAgent.py 5f66e2a 
>   ambari-server/src/test/python/custom_actions/TestRemoveBits.py PRE-CREATION 
>   ambari-server/src/test/python/custom_actions/test_ru_set_all.py 162a2fd 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py b011f93 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 18e25c0 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus_prod.py 74877af 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py 8017ec2 
> 
> Diff: https://reviews.apache.org/r/41264/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>