You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/02/24 02:12:32 UTC

[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #19947: [wip][V1.8.x] Attemp to fix cd for v1.8.x

Zha0q1 opened a new pull request #19947:
URL: https://github.com/apache/incubator-mxnet/pull/19947


   Based off https://github.com/apache/incubator-mxnet/pull/19946


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #19947: [wip][V1.8.x] Attemp to fix cd for v1.8.x

Posted by GitBox <gi...@apache.org>.
josephevans commented on a change in pull request #19947:
URL: https://github.com/apache/incubator-mxnet/pull/19947#discussion_r582115137



##########
File path: cd/python/docker/Dockerfile
##########
@@ -23,11 +23,15 @@
 ARG BASE_IMAGE
 FROM ${BASE_IMAGE}
 
-ARG PYTHON_CMD=python3
-RUN apt-get update && \
-    apt-get install -y wget ${PYTHON_CMD}-dev gcc && \
-    wget https://bootstrap.pypa.io/get-pip.py && \
-    ${PYTHON_CMD} get-pip.py
+RUN apt-get update || true

Review comment:
       Could you combine all these RUN commands into one? Each RUN command causes a docker layer to be saved, so it's more efficient to do
   ```
   RUN apt-get update && \
       apt-get install -y software-properties-common && \
       add-apt-repository -y ppa:deadsnakes/ppa && \
       apt-get update && \
       apt-get install -y python3.7-dev python3.7-distutils virtualenv wget && \
       ln -sf /usr/bin/python3.7 /usr/local/bin/python3 && \
       wget -nv https://bootstrap.pypa.io/get-pip.py && \
       python3 get-pip.py
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19947: [wip][V1.8.x] Attemp to fix cd for v1.8.x

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19947:
URL: https://github.com/apache/incubator-mxnet/pull/19947#issuecomment-784695675


   Hey @Zha0q1 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-cpu, unix-gpu, windows-gpu, sanity, edge, website, clang, centos-cpu, miscellaneous, centos-gpu, unix-cpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 merged pull request #19947: [V1.8.x] Attemp to fix cd for v1.8.x

Posted by GitBox <gi...@apache.org>.
Zha0q1 merged pull request #19947:
URL: https://github.com/apache/incubator-mxnet/pull/19947


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19947: [V1.8.x] Attemp to fix cd for v1.8.x

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #19947:
URL: https://github.com/apache/incubator-mxnet/pull/19947#discussion_r584400357



##########
File path: cd/python/docker/Dockerfile
##########
@@ -23,11 +23,15 @@
 ARG BASE_IMAGE
 FROM ${BASE_IMAGE}
 
-ARG PYTHON_CMD=python3
-RUN apt-get update && \
-    apt-get install -y wget ${PYTHON_CMD}-dev gcc && \
-    wget https://bootstrap.pypa.io/get-pip.py && \
-    ${PYTHON_CMD} get-pip.py
+RUN apt-get update || true

Review comment:
       Fixed!
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org