You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/09 08:48:58 UTC
[GitHub] [incubator-nuttx-apps] jerpelea opened a new pull request #1056: examples: migrate licenses to Apache
jerpelea opened a new pull request #1056:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1056
## Summary
Gregory Nutt is the copyright holder for those files and he has submitted the
SGA as a result we can migrate the licenses to Apache.
## Impact
LICENSE
## Testing
NONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1056: examples: migrate licenses to Apache
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #1056:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1056#discussion_r822515099
##########
File path: examples/lis3dsh_reader/lis3dsh_reader_main.c
##########
@@ -49,7 +53,7 @@
#include <nuttx/sensors/lis3dsh.h>
/****************************************************************************
- * lis3dsh_reader_main
Review comment:
I see that many source files keep both. Example:
```
/****************************************************************************
* Public Functions
****************************************************************************/
/****************************************************************************
* renew_main
****************************************************************************/
int main(int argc, FAR char *argv[])
```
So can we add `Public Functions` instead of replacing `lis3dsh_reader_main`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1056: examples: migrate licenses to Apache
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #1056:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1056#discussion_r822423530
##########
File path: examples/lis3dsh_reader/lis3dsh_reader_main.c
##########
@@ -49,7 +53,7 @@
#include <nuttx/sensors/lis3dsh.h>
/****************************************************************************
- * lis3dsh_reader_main
Review comment:
Why is this changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on a change in pull request #1056: examples: migrate licenses to Apache
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #1056:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1056#discussion_r822435714
##########
File path: examples/lis3dsh_reader/lis3dsh_reader_main.c
##########
@@ -49,7 +53,7 @@
#include <nuttx/sensors/lis3dsh.h>
/****************************************************************************
- * lis3dsh_reader_main
Review comment:
for cleanup, I replaced "lis3dsh_reader_main" with "Private Functions" which is a required string instead of adding a new "Private Functions" block.
##########
File path: examples/lis3dsh_reader/lis3dsh_reader_main.c
##########
@@ -49,7 +53,7 @@
#include <nuttx/sensors/lis3dsh.h>
/****************************************************************************
- * lis3dsh_reader_main
Review comment:
for cleanup, I replaced "lis3dsh_reader_main" with "Private Functions" which is a required string instead of adding a new "Private Functions" block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1056: examples: migrate licenses to Apache
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1056:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #1056: examples: migrate licenses to Apache
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1056:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1056#issuecomment-1062843247
please ignore pdcourses nxstyle warnings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1056: examples: migrate licenses to Apache
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1056:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1056#discussion_r822521490
##########
File path: examples/lis3dsh_reader/lis3dsh_reader_main.c
##########
@@ -49,7 +53,7 @@
#include <nuttx/sensors/lis3dsh.h>
/****************************************************************************
- * lis3dsh_reader_main
Review comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1056: examples: migrate licenses to Apache
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1056:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1056#discussion_r822442597
##########
File path: examples/lis3dsh_reader/lis3dsh_reader_main.c
##########
@@ -49,7 +53,7 @@
#include <nuttx/sensors/lis3dsh.h>
/****************************************************************************
- * lis3dsh_reader_main
Review comment:
But it should be "Public Functions" here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org