You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "Curverneur (via GitHub)" <gi...@apache.org> on 2025/11/21 23:31:05 UTC

[PR] add option to configure destination cidr in egress firewall rules [cloudstack-terraform-provider]

Curverneur opened a new pull request, #265:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/265

   ## Description
   This PR introduces support for configuring a destination network in outgoing firewall rules, a feature introduced in [API v4.10](https://cloudstack.apache.org/api/apidocs-4.10/apis/createEgressFirewallRule.html). The change is backward-compatible and not a breaking change, allowing users to optionally specify `dest_cidr_list` in their configuration.
   
   ## References
   API: https://cloudstack.apache.org/api/apidocs-4.22/apis/createEgressFirewallRule.html
   
   ## Changes
   Added `dest_cidr_list` option to the rules block of `cloudstack_egress_firewall` and updated the documentation page accordingly.
   - modified `cloudstack/resource_cloudstack_egress_firewall.go`
   - modified `website/docs/r/egress_firewall.html.markdown`
   
   <img height="400" alt="dest_cidr_empty" src="https://github.com/user-attachments/assets/10a622f8-71ac-4c19-8f9e-acf58a6a3097" />
   <img height="400" alt="dest_cidr_filled" src="https://github.com/user-attachments/assets/3ca39ac4-ae01-473d-9d35-cd5da8517214" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] add option to configure destination cidr in egress firewall rules [cloudstack-terraform-provider]

Posted by "sudo87 (via GitHub)" <gi...@apache.org>.
sudo87 commented on PR #265:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/265#issuecomment-5312034957

   Closing as superseded by [#298](https://github.com/apache/cloudstack-terraform-provider/pull/298), which includes this same change plus the missing create/read wiring. See #296 for details. Thanks for the work here @Curverneur!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] add option to configure destination cidr in egress firewall rules [cloudstack-terraform-provider]

Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on code in PR #265:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/265#discussion_r3241061984


##########
cloudstack/resource_cloudstack_egress_firewall.go:
##########
@@ -70,6 +70,13 @@ func resourceCloudStackEgressFirewall() *schema.Resource {
 							Set:      schema.HashString,
 						},
 
+						"dest_cidr_list": {

Review Comment:
   I haven't tested but doesn't `createEgressFirewallRule` need to set the `dest_cidr_list` in the params?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] add option to configure destination cidr in egress firewall rules [cloudstack-terraform-provider]

Posted by "sudo87 (via GitHub)" <gi...@apache.org>.
sudo87 closed pull request #265: add option to configure destination cidr in egress firewall rules
URL: https://github.com/apache/cloudstack-terraform-provider/pull/265


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org