You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/03/30 01:08:07 UTC
[GitHub] brooklyn-server pull request: reduce number of events and log
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/90
reduce number of events and log
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server fix/reduce-and-log-events
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/90.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #90
----
commit 2862a39acc7e42cf78af421debdcaa35e046bc84
Author: Aled Sage <al...@gmail.com>
Date: 2016-03-29T23:06:17Z
Use suppressDuplicates for various sensors
commit 182e2e3a9f2994b0e343f78443e008684193539f
Author: Aled Sage <al...@gmail.com>
Date: 2016-03-29T23:06:56Z
BasicExecutionManager tidy: use Set instead of Map
For incompleteTaskIds
commit a7a437c81dc62b9f8751387bf7d8eeac3597b0c8
Author: Aled Sage <al...@gmail.com>
Date: 2016-03-29T23:07:31Z
Log.debug every 1000 events for each subscription
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: reduce number of events and log
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/90#discussion_r57858123
--- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalSubscriptionManager.java ---
@@ -143,6 +143,9 @@ public void run() {
if (s.eventFilter!=null && !s.eventFilter.apply(event))
return;
try {
+ int count = s.eventCount.incrementAndGet();
+ if (count > 0 && count % 1000 == 0) LOG.debug("{} events for subscriber {}", count, s);
--- End diff --
will always be > 0 due to line above
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: reduce number of events and log
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/90
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: reduce number of events and log
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-server/pull/90#issuecomment-203339569
LGTM - logging is nice
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---