You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/02/05 22:05:53 UTC

Review Request 43260: Add net::IP parsing template to the flags parsers.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43260/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.


Bugs: MESOS-4609
    https://issues.apache.org/jira/browse/MESOS-4609


Repository: mesos


Description
-------

This will allow us to add flags of type `net::IP`.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 295eac77d5aba4084bbc044d94f45d660410d725 

Diff: https://reviews.apache.org/r/43260/diff/


Testing
-------

make

Tests are run in the next review.


Thanks,

Joseph Wu


Re: Review Request 43260: Add net::IP parsing template to the flags parsers.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43260/
-----------------------------------------------------------

(Updated Feb. 18, 2016, 11:07 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.


Changes
-------

fix depends on field. -- @vinodkone


Bugs: MESOS-4609
    https://issues.apache.org/jira/browse/MESOS-4609


Repository: mesos


Description
-------

This will allow us to add flags of type `net::IP`.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 295eac77d5aba4084bbc044d94f45d660410d725 

Diff: https://reviews.apache.org/r/43260/diff/


Testing
-------

make

Tests are run in the next review.


Thanks,

Joseph Wu


Re: Review Request 43260: Add net::IP parsing template to the flags parsers.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43260/
-----------------------------------------------------------

(Updated Feb. 18, 2016, 10:58 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.


Changes
-------

Temporrarily setting "depends_on" field for testing reviewbot. -- @vinodkone.


Bugs: MESOS-4609
    https://issues.apache.org/jira/browse/MESOS-4609


Repository: mesos


Description
-------

This will allow us to add flags of type `net::IP`.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 295eac77d5aba4084bbc044d94f45d660410d725 

Diff: https://reviews.apache.org/r/43260/diff/


Testing
-------

make

Tests are run in the next review.


Thanks,

Joseph Wu