[GitHub] [accumulo] milleruntime commented on a diff in pull request #2976: Drop ReadOnlyStore in favor of polymorphism in FaTE

[GitBox <gi...@apache.org>]

milleruntime commented on code in PR #2976:
URL: https://github.com/apache/accumulo/pull/2976#discussion_r982452913


##########
server/base/src/main/java/org/apache/accumulo/server/util/Admin.java:
##########
@@ -795,25 +794,22 @@ private void executeFateOpsCommand(ServerContext context, FateOpsCommand fateOps
       }
     }
 
-    ReadOnlyStore<Admin> readOnlyStore = new ReadOnlyStore<>(zs);
-
     if (fateOpsCommand.print) {
       final Set<Long> sortedTxs = new TreeSet<>();
       fateOpsCommand.txList.forEach(s -> sortedTxs.add(parseTidFromUserInput(s)));
       if (!fateOpsCommand.txList.isEmpty()) {
         EnumSet<ReadOnlyTStore.TStatus> statusFilter =
             getCmdLineStatusFilters(fateOpsCommand.states);
-        admin.print(readOnlyStore, zk, zTableLocksPath, new Formatter(System.out), sortedTxs,
-            statusFilter);
+        admin.print(zs, zk, zTableLocksPath, new Formatter(System.out), sortedTxs, statusFilter);

Review Comment:
   No need. The call to the method takes care of that for you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org