[jira] [Commented] (TINKERPOP-1267) Configure Console for no timeout on remote requests

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257941#comment-15257941 ] 

ASF GitHub Bot commented on TINKERPOP-1267:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/294

    TINKERPOP-1267 Added option for "none" on remote timeouts.

    Added some tests to validate the new timeout setting and did some manual tests:
    
    ```text
    gremlin> :remote connect tinkerpop.server conf/remote.yaml
    ==>Connected - localhost/127.0.0.1:8182
    gremlin> :remote config timeout max
    ==>Set remote timeout to 2147483647ms
    gremlin> :remote config timeout none
    ==>Remote timeout is disable
    gremlin> :remote config timeout 10000
    ==>Set remote timeout to 10000ms
    gremlin> :> Thread.sleep(9000)
    ==>null
    gremlin> :> Thread.sleep(11000)
    Request timed out while processing - increase the timeout with the :remote command
    Display stack trace? [yN] n
    ```
    
    Successful run of `mvn clean install && mvn verify -pl gremlin-console -DskipIntegrationTests=false`
    
    VOTE +1


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1267

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #294
    
----

----


> Configure Console for no timeout on remote requests
> ---------------------------------------------------
>
>                 Key: TINKERPOP-1267
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1267
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: console
>    Affects Versions: 3.1.2-incubating
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Minor
>             Fix For: 3.1.3
>
>
> The console comes with a default timeout of 3 minutes for remote requests to Gremlin Server. You can change that value with:
> {code}
> :remote config timeout 60000
> {code} 
> or you can make it "basically" indefinite with:
> {code}
> :remote config timeout max
> {code} 
> I think "max" is kinda weird now that I look at it. That basically sets a time out for {{Integer.MAX_VALUE}} when you really just want to wait indefinitely and have no timeout at all. I guess "max" is just a sort of a bad word. It seems like it would be good to deprecate "max" in favor of:
> {code}
> :remote config timeout none
> {code} 
> which is more in line with what someone actually wants to have when they are doing "max".
> Change the default timeout from 3 minutes to "none". It seems to be the more expected default. Can't think of a circumstance in the context of the console, where the client shouldn't just wait for the server's response.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)