[jira] [Commented] (VCL-851) Prevent warning in vcld.log if vSphere SDK is not installed

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VCL-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507773#comment-14507773 ] 

ASF subversion and git services commented on VCL-851:
-----------------------------------------------------

Commit 1675483 from [~arkurth] in branch 'vcl/trunk'
[ https://svn.apache.org/r1675483 ]

VCL-844
Added subroutines to VMware.pm:
* get_vmx_url_base_directory_path
* get_vmx_intermediate_directory_path
* _get_datastore_url
* _get_url_path
* configure_vmhost_ssh_keys
* copy_vmhost_ssh_public_key_to_another_host
* copy_file_to_another_host
* setup_migrate_vm
* migrate_vm
* migrate_revert_source

Added subroutines to utils.pm:
* update_computer_vmhost_id.
* setup_get_hash_multiple_choice.

Updated Module.pm::new to call initialize on ManagementNode.pm objects even if $SETUP_MODE is true.

Updated Module.pm::create_object to accept an additional argument which allows arguments to be passed to the constructor of the object being created as well as the DataStructure.pm object.

Updated Module.pm::create_vmhost_os_object to accept an argument specifying which VM host to create an object for.

Updated DataStructure.pm to accept a vmhost_identifier argument rather than use a vmhost_id argument.

Changed where cached data is stored from %ENV to $self in order to allow it to work with multiple VMware.pm objects.


VCL-851
Added check to skip the attempt to use vSphere_SDK.pm if vmprofile.password is not configured.

> Prevent warning in vcld.log if vSphere SDK is not installed
> -----------------------------------------------------------
>
>                 Key: VCL-851
>                 URL: https://issues.apache.org/jira/browse/VCL-851
>             Project: VCL
>          Issue Type: Improvement
>          Components: vcld (backend)
>            Reporter: Andy Kurth
>            Assignee: Andy Kurth
>            Priority: Trivial
>
> {{vSphereSDK.pm::initialize}} is needlessly displaying the following in _vcld.log_ if the SDK is not installed:
> {noformat}2015-04-01 16:09:12|26198|2375|3115|test|vSphere_SDK.pm:initialize|98|vSphere SDK for Perl does not appear to be installed on this managment node, unable to load VMware vSphere SDK Perl modules, error:
> |26198|2375|3115|test|vSphere_SDK.pm:initialize|98| Can't locate VMware/VIRuntime.pm in @INC (@INC contains: /usr/local/vclclean/bin/../../../.. /usr/local/vclclean/bin/../.. /usr/local/vclclean/bin/../../.. /usr/local/vclclean/bin/.. /usr/local/vclclean/bin/../lib /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at (eval 273) line 1.
> |26198|2375|3115|test|vSphere_SDK.pm:initialize|98| BEGIN failed--compilation aborted at (eval 273) line 1.{noformat}
> After the code attempts to load the SDK modules, it checks if the VM profile username and password are configured.  If not, it returns.  Moving the loading of the SDK modules to after the username/password defined check will prevent the warning from appearing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)