You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/08/23 08:15:56 UTC
Review Request 68483: Fixed argument parsing in python 3 support
script mesos-gtest-runner.py.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68483/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-9179
https://issues.apache.org/jira/browse/MESOS-9179
Repository: mesos
Description
-------
Fixed argument parsing in python 3 support script mesos-gtest-runner.py.
Diffs
-----
support/python3/mesos-gtest-runner.py 2edc73d9316e1b55de2025fcf8028c0e508a620f
Diff: https://reviews.apache.org/r/68483/diff/1/
Testing
-------
```
python3 (master) $ python3 mesos-gtest-runner.py --help
usage: mesos-gtest-runner.py [-h] [-j JOBS]
optional arguments:
-h, --help show this help message and exit
-j JOBS, --jobs JOBS number of parallel jobs to spawn. DEFAULT: 6
The environment variable MESOS_GTEST_RUNNER_FLAGS can be used to set a default
set of flags. Flags passed on the command line always have precedence over
these defaults.
```
Thanks,
Armand Grillet
Re: Review Request 68483: Fixed argument parsing in python 3 support
script mesos-gtest-runner.py.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68483/#review207809
-----------------------------------------------------------
PASS: Mesos patch 68483 was successfully built and tested.
Reviews applied: `['68483']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2224/mesos-review-68483
- Mesos Reviewbot Windows
On Aug. 23, 2018, 8:15 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68483/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 8:15 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9179
> https://issues.apache.org/jira/browse/MESOS-9179
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed argument parsing in python 3 support script mesos-gtest-runner.py.
>
>
> Diffs
> -----
>
> support/python3/mesos-gtest-runner.py 2edc73d9316e1b55de2025fcf8028c0e508a620f
>
>
> Diff: https://reviews.apache.org/r/68483/diff/1/
>
>
> Testing
> -------
>
> ```
> python3 (master) $ python3 mesos-gtest-runner.py --help
> usage: mesos-gtest-runner.py [-h] [-j JOBS]
>
> optional arguments:
> -h, --help show this help message and exit
> -j JOBS, --jobs JOBS number of parallel jobs to spawn. DEFAULT: 6
>
> The environment variable MESOS_GTEST_RUNNER_FLAGS can be used to set a default
> set of flags. Flags passed on the command line always have precedence over
> these defaults.
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68483: Fixed argument parsing in python 3 support
script mesos-gtest-runner.py.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68483/#review207811
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68483]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 23, 2018, 8:15 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68483/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 8:15 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9179
> https://issues.apache.org/jira/browse/MESOS-9179
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed argument parsing in python 3 support script mesos-gtest-runner.py.
>
>
> Diffs
> -----
>
> support/python3/mesos-gtest-runner.py 2edc73d9316e1b55de2025fcf8028c0e508a620f
>
>
> Diff: https://reviews.apache.org/r/68483/diff/1/
>
>
> Testing
> -------
>
> ```
> python3 (master) $ python3 mesos-gtest-runner.py --help
> usage: mesos-gtest-runner.py [-h] [-j JOBS]
>
> optional arguments:
> -h, --help show this help message and exit
> -j JOBS, --jobs JOBS number of parallel jobs to spawn. DEFAULT: 6
>
> The environment variable MESOS_GTEST_RUNNER_FLAGS can be used to set a default
> set of flags. Flags passed on the command line always have precedence over
> these defaults.
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68483: Fixed argument parsing in python 3 support
script mesos-gtest-runner.py.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68483/#review208251
-----------------------------------------------------------
PASS: Mesos patch 68483 was successfully built and tested.
Reviews applied: `['68483']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2279/mesos-review-68483
- Mesos Reviewbot Windows
On Aug. 24, 2018, 11:10 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68483/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 11:10 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9179
> https://issues.apache.org/jira/browse/MESOS-9179
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed argument parsing in python 3 support script mesos-gtest-runner.py.
>
>
> Diffs
> -----
>
> support/python3/mesos-gtest-runner.py 2edc73d9316e1b55de2025fcf8028c0e508a620f
>
>
> Diff: https://reviews.apache.org/r/68483/diff/4/
>
>
> Testing
> -------
>
> ```
> python3 (master) $ python3 mesos-gtest-runner.py --help
> usage: mesos-gtest-runner.py [-h] [-j JOBS]
>
> optional arguments:
> -h, --help show this help message and exit
> -j JOBS, --jobs JOBS number of parallel jobs to spawn. DEFAULT: 6
>
> The environment variable MESOS_GTEST_RUNNER_FLAGS can be used to set a default
> set of flags. Flags passed on the command line always have precedence over
> these defaults.
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68483: Fixed argument parsing in python 3 support
script mesos-gtest-runner.py.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68483/#review207873
-----------------------------------------------------------
PASS: Mesos patch 68483 was successfully built and tested.
Reviews applied: `['68483']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2232/mesos-review-68483
- Mesos Reviewbot Windows
On Aug. 24, 2018, 11:10 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68483/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 11:10 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9179
> https://issues.apache.org/jira/browse/MESOS-9179
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed argument parsing in python 3 support script mesos-gtest-runner.py.
>
>
> Diffs
> -----
>
> support/python3/mesos-gtest-runner.py 2edc73d9316e1b55de2025fcf8028c0e508a620f
>
>
> Diff: https://reviews.apache.org/r/68483/diff/2/
>
>
> Testing
> -------
>
> ```
> python3 (master) $ python3 mesos-gtest-runner.py --help
> usage: mesos-gtest-runner.py [-h] [-j JOBS]
>
> optional arguments:
> -h, --help show this help message and exit
> -j JOBS, --jobs JOBS number of parallel jobs to spawn. DEFAULT: 6
>
> The environment variable MESOS_GTEST_RUNNER_FLAGS can be used to set a default
> set of flags. Flags passed on the command line always have precedence over
> these defaults.
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68483: Fixed argument parsing in python 3 support
script mesos-gtest-runner.py.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68483/#review208252
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Sept. 3, 2018, 12:09 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68483/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2018, 12:09 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9179
> https://issues.apache.org/jira/browse/MESOS-9179
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed argument parsing in python 3 support script mesos-gtest-runner.py.
>
>
> Diffs
> -----
>
> support/python3/mesos-gtest-runner.py 2edc73d9316e1b55de2025fcf8028c0e508a620f
>
>
> Diff: https://reviews.apache.org/r/68483/diff/5/
>
>
> Testing
> -------
>
> ```
> python3 (master) $ python3 mesos-gtest-runner.py --help
> usage: mesos-gtest-runner.py [-h] [-j JOBS]
>
> optional arguments:
> -h, --help show this help message and exit
> -j JOBS, --jobs JOBS number of parallel jobs to spawn. DEFAULT: 6
>
> The environment variable MESOS_GTEST_RUNNER_FLAGS can be used to set a default
> set of flags. Flags passed on the command line always have precedence over
> these defaults.
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68483: Fixed argument parsing in python 3 support
script mesos-gtest-runner.py.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68483/#review208256
-----------------------------------------------------------
PASS: Mesos patch 68483 was successfully built and tested.
Reviews applied: `['68483']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2280/mesos-review-68483
- Mesos Reviewbot Windows
On Sept. 3, 2018, 10:09 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68483/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2018, 10:09 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9179
> https://issues.apache.org/jira/browse/MESOS-9179
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed argument parsing in python 3 support script mesos-gtest-runner.py.
>
>
> Diffs
> -----
>
> support/python3/mesos-gtest-runner.py 2edc73d9316e1b55de2025fcf8028c0e508a620f
>
>
> Diff: https://reviews.apache.org/r/68483/diff/5/
>
>
> Testing
> -------
>
> ```
> python3 (master) $ python3 mesos-gtest-runner.py --help
> usage: mesos-gtest-runner.py [-h] [-j JOBS]
>
> optional arguments:
> -h, --help show this help message and exit
> -j JOBS, --jobs JOBS number of parallel jobs to spawn. DEFAULT: 6
>
> The environment variable MESOS_GTEST_RUNNER_FLAGS can be used to set a default
> set of flags. Flags passed on the command line always have precedence over
> these defaults.
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68483: Fixed argument parsing in python 3 support
script mesos-gtest-runner.py.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68483/#review208253
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68483]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 3, 2018, 12:09 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68483/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2018, 12:09 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9179
> https://issues.apache.org/jira/browse/MESOS-9179
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed argument parsing in python 3 support script mesos-gtest-runner.py.
>
>
> Diffs
> -----
>
> support/python3/mesos-gtest-runner.py 2edc73d9316e1b55de2025fcf8028c0e508a620f
>
>
> Diff: https://reviews.apache.org/r/68483/diff/5/
>
>
> Testing
> -------
>
> ```
> python3 (master) $ python3 mesos-gtest-runner.py --help
> usage: mesos-gtest-runner.py [-h] [-j JOBS]
>
> optional arguments:
> -h, --help show this help message and exit
> -j JOBS, --jobs JOBS number of parallel jobs to spawn. DEFAULT: 6
>
> The environment variable MESOS_GTEST_RUNNER_FLAGS can be used to set a default
> set of flags. Flags passed on the command line always have precedence over
> these defaults.
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68483: Fixed argument parsing in python 3 support
script mesos-gtest-runner.py.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68483/
-----------------------------------------------------------
(Updated Sept. 3, 2018, 12:09 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Resolved `str` issue.
Bugs: MESOS-9179
https://issues.apache.org/jira/browse/MESOS-9179
Repository: mesos
Description
-------
Fixed argument parsing in python 3 support script mesos-gtest-runner.py.
Diffs (updated)
-----
support/python3/mesos-gtest-runner.py 2edc73d9316e1b55de2025fcf8028c0e508a620f
Diff: https://reviews.apache.org/r/68483/diff/5/
Changes: https://reviews.apache.org/r/68483/diff/4-5/
Testing
-------
```
python3 (master) $ python3 mesos-gtest-runner.py --help
usage: mesos-gtest-runner.py [-h] [-j JOBS]
optional arguments:
-h, --help show this help message and exit
-j JOBS, --jobs JOBS number of parallel jobs to spawn. DEFAULT: 6
The environment variable MESOS_GTEST_RUNNER_FLAGS can be used to set a default
set of flags. Flags passed on the command line always have precedence over
these defaults.
```
Thanks,
Armand Grillet
Re: Review Request 68483: Fixed argument parsing in python 3 support
script mesos-gtest-runner.py.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68483/#review207891
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68483]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 24, 2018, 11:10 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68483/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 11:10 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9179
> https://issues.apache.org/jira/browse/MESOS-9179
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed argument parsing in python 3 support script mesos-gtest-runner.py.
>
>
> Diffs
> -----
>
> support/python3/mesos-gtest-runner.py 2edc73d9316e1b55de2025fcf8028c0e508a620f
>
>
> Diff: https://reviews.apache.org/r/68483/diff/2/
>
>
> Testing
> -------
>
> ```
> python3 (master) $ python3 mesos-gtest-runner.py --help
> usage: mesos-gtest-runner.py [-h] [-j JOBS]
>
> optional arguments:
> -h, --help show this help message and exit
> -j JOBS, --jobs JOBS number of parallel jobs to spawn. DEFAULT: 6
>
> The environment variable MESOS_GTEST_RUNNER_FLAGS can be used to set a default
> set of flags. Flags passed on the command line always have precedence over
> these defaults.
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68483: Fixed argument parsing in python 3 support
script mesos-gtest-runner.py.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68483/
-----------------------------------------------------------
(Updated Aug. 24, 2018, 1:10 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Improved and better tested.
Bugs: MESOS-9179
https://issues.apache.org/jira/browse/MESOS-9179
Repository: mesos
Description
-------
Fixed argument parsing in python 3 support script mesos-gtest-runner.py.
Diffs (updated)
-----
support/python3/mesos-gtest-runner.py 2edc73d9316e1b55de2025fcf8028c0e508a620f
Diff: https://reviews.apache.org/r/68483/diff/2/
Changes: https://reviews.apache.org/r/68483/diff/1-2/
Testing
-------
```
python3 (master) $ python3 mesos-gtest-runner.py --help
usage: mesos-gtest-runner.py [-h] [-j JOBS]
optional arguments:
-h, --help show this help message and exit
-j JOBS, --jobs JOBS number of parallel jobs to spawn. DEFAULT: 6
The environment variable MESOS_GTEST_RUNNER_FLAGS can be used to set a default
set of flags. Flags passed on the command line always have precedence over
these defaults.
```
Thanks,
Armand Grillet