You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Alex Burkhart (JIRA)" <ji...@apache.org> on 2009/10/10 02:10:31 UTC

[jira] Created: (THRIFT-603) Struct read method does not call validate

Struct read method does not call validate
-----------------------------------------

                 Key: THRIFT-603
                 URL: https://issues.apache.org/jira/browse/THRIFT-603
             Project: Thrift
          Issue Type: Bug
          Components: Library (Ruby)
    Affects Versions: 0.1
         Environment: Thrift gem 0.1.0.1, Ruby 1.8.6
            Reporter: Alex Burkhart


The C implementation of the struct read method fails to call validate after read. The write method already calls validate before attempting to write the struct. This inconsistency allows an object to be serialized and then deserialized as an invalid object (ex. missing required fields).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (THRIFT-603) Struct read method does not call validate

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury resolved THRIFT-603.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.2
         Assignee: Alex Burkhart

I just committed this fix. Thanks for the patch, Alex!

> Struct read method does not call validate
> -----------------------------------------
>
>                 Key: THRIFT-603
>                 URL: https://issues.apache.org/jira/browse/THRIFT-603
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>    Affects Versions: 0.1
>         Environment: Thrift gem 0.1.0.1, Ruby 1.8.6
>            Reporter: Alex Burkhart
>            Assignee: Alex Burkhart
>             Fix For: 0.2
>
>         Attachments: read_validate.patch
>
>
> The C implementation of the struct read method fails to call validate after read. The write method already calls validate before attempting to write the struct. This inconsistency allows an object to be serialized and then deserialized as an invalid object (ex. missing required fields).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (THRIFT-603) Struct read method does not call validate

Posted by "Alex Burkhart (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Burkhart updated THRIFT-603:
---------------------------------

    Attachment: read_validate.patch

I believe this is all that is necessary.

> Struct read method does not call validate
> -----------------------------------------
>
>                 Key: THRIFT-603
>                 URL: https://issues.apache.org/jira/browse/THRIFT-603
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>    Affects Versions: 0.1
>         Environment: Thrift gem 0.1.0.1, Ruby 1.8.6
>            Reporter: Alex Burkhart
>         Attachments: read_validate.patch
>
>
> The C implementation of the struct read method fails to call validate after read. The write method already calls validate before attempting to write the struct. This inconsistency allows an object to be serialized and then deserialized as an invalid object (ex. missing required fields).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.